fix: Fixing prompts import warning #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
leseb
reviewed
Sep 16, 2025
leseb
reviewed
Sep 16, 2025
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
fix-prompt-api-import
branch
from
c2ac317 to
9fc0696
Compare
leseb
reviewed
Sep 16, 2025
franciscojavierarceo
force-pushed
the
fix-prompt-api-import
branch
from
16f7686 to
9fc0696
Compare
Let me know if i missed something though! |
cdoern
approved these changes
Sep 16, 2025
llama_stack/core/distribution.py
Outdated
| def providable_apis() -> list[Api]: | ||
| routing_table_apis = {x.routing_table_api for x in builtin_automatically_routed_apis()} | ||
| return [api for api in Api if api not in routing_table_apis and api != Api.inspect and api != Api.providers] | ||
| internal_apis = {Api.inspect, Api.providers, Api.prompts} |
There was a problem hiding this comment.
yeah, I have this in a branch as well. This is the right fix! thanks
+1 |
ehhuang
reviewed
Sep 16, 2025
Comment on lines
155
to
166
| def test_internal_apis_excluded(self): | ||
| """Test that internal APIs are excluded and other APIs are included in providable APIs.""" | ||
| apis = providable_apis() | ||
| internal_apis = {Api.inspect, Api.providers, Api.prompts} | ||
|
|
||
| for internal_api in internal_apis: | ||
| assert internal_api not in apis, f"Internal API {internal_api} should not be in providable_apis" | ||
|
|
||
| included_apis = {Api.inference, Api.safety, Api.agents} | ||
| for api in included_apis: | ||
| assert api in apis, f"API {api} should be in providable_apis" | ||
|
|
There was a problem hiding this comment.
while this verifies the change in this PR, this test does not prevent new providers from running into the same issue. I wonder if we can add a test that catches the current issue that's fixed by this PR?
There was a problem hiding this comment.
How about a global that can be imported and tested against?
There was a problem hiding this comment.
like a fixture? yea i think that can work
There was a problem hiding this comment.
mind taking a look at the latest change? if you're good with it, feel free to merge. I confirmed it'll fail the test by raising the import error for the registry (since APIs of this nature should not have a registry).
ehhuang
approved these changes
Sep 16, 2025
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
leseb
approved these changes
Sep 17, 2025
iamemilio
pushed a commit
to iamemilio/llama-stack
that referenced
this pull request
Sep 24, 2025
# What does this PR do?
Fixes this warning in llama stack build:
```bash
WARNING 2025-09-15 15:29:02,197 llama_stack.core.distribution:149 core: Failed to import module prompts: No module named
'llama_stack.providers.registry.prompts'"
```
## Test Plan
Test added
---------
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes this warning in llama stack build:
WARNING 2025-09-15 15:29:02,197 llama_stack.core.distribution:149 core: Failed to import module prompts: No module named 'llama_stack.providers.registry.prompts'"Test Plan
Test added