Solution and Test for issue #58 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songz
reviewed
Jun 13, 2017
test/58.js
Outdated
| // solution = require('../yourSolution').solution; | ||
|
|
||
| describe('return smallest number of coins required to return the change', () => { | ||
| class Employee { |
There was a problem hiding this comment.
import this from solution. Doesn't make sense for Employee to be part of tests.
songz
reviewed
Jun 13, 2017
solutions/58.js
Outdated
| }); | ||
| }); | ||
|
|
||
| if (funValWithoutEmp > funValWithEmp) { |
There was a problem hiding this comment.
return funValWithoutEmp > funValWithEmp ? funValWithoutEmp : funValWithEmp;
songz
requested changes
Jun 13, 2017
test/58.js
Outdated
| // solution = require('../yourSolution').solution; | ||
|
|
||
| describe('return smallest number of coins required to return the change', () => { | ||
| class Employee { |
songz
reviewed
Jun 14, 2017
solutions/58.js
Outdated
| * @param {Employee} emp - an Employee with fun value and a list of his staff | ||
| * @returns {Employee []]} list - Array of employees that creates the maximum fun | ||
| */ | ||
|
|
There was a problem hiding this comment.
almost there! remove empty line
songz
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a guest list for Max fun