Update logic of response generation in case of dataset usage #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will be added to readme - move all sqlite related code in custom dataset to helper class - update dataset tests accordingly - remove duplicated definitions - open sqlite db in read-only mode, this will allow to support datasets in DP mode - do not allow dataset definition in echo mode Signed-off-by: Maya Barnea <mayab@il.ibm.com>
- Separate between loading custom dataset from a local file and dataset download - If custom dataset's url is defined in command line - download the dataset before initializing simulator(s) Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
irar2
reviewed
Nov 16, 2025
…y PR comments Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
…s added for GetTokens to improve coverage Signed-off-by: Maya Barnea <mayab@il.ibm.com>
irar2
reviewed
Nov 17, 2025
pkg/dataset/dataset_test.go
Outdated
| {47, []bucketBoundaries{{1, 9}, {10, 18}, {19, 27}, {28, 36}, {37, 46}}}, | ||
| {50, []bucketBoundaries{{1, 9}, {10, 19}, {20, 29}, {30, 39}, {40, 49}}}} | ||
|
|
||
| for _, test := range tests { |
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
irar2
approved these changes
Nov 18, 2025
Collaborator
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247