Improve mos-sim trace ergonomics #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lashtear
commented
Nov 21, 2025
lashtear
commented
- Changes to --trace formatting to show flag breakdown and instruction stream
- Change 0xfff7 and 0xfff8 to print their final trace line before exiting
- Change to 0xfffe to also trigger halt on read for BRK intercept
mysterymath
approved these changes
Nov 23, 2025
utils/sim/mos-sim.c
Outdated
| if (shouldTrace) | ||
| fprintf(stderr, "%04x a:%02x x:%02x y:%02x s: %02x st:%02x\n", pc, a, x, | ||
| y, sp, status); | ||
| if (shouldTrace){ |
utils/sim/mos-sim.c
Outdated
| char status_buf[9]; | ||
| status_buf[8] = '\0'; | ||
|
|
||
| const char statuses[] = "czidb1vn"; |
Member
There was a problem hiding this comment.
nit: Move these both into the loop right before they're used. Moving them out is the compiler's job :P
* Whitespace * De-hoist the invariants, make that compiler work for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.