Skip to content

Conversation

@harlanhaskins
Copy link
Member

This abstracts the built-in ExecutionEngine JIT. We should use this until we can get the ORCJIT bindings to build with SwiftPM.

@harlanhaskins harlanhaskins requested a review from CodaFi January 11, 2017 05:16
Copy link
Member

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo nits, LGTM.

@@ -0,0 +1,112 @@
import cllvm

/// JITError represents the different kinds of errors the JIT compiler can throw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: period

}
}

/// A JIT is a Just-In-Time compiler that will compile and execute LLVM IR that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: code voice for class names.

/// return the value the function generated, allowing you to write interactive
/// programs that will run as soon as they are compiled.
class JIT {
/// The underlying LLVMExecutionEngineRef backing this JIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: period

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm here: public final class JIT please



/// Runs the specified function with the provided arguments by compiling
/// it to machine code for your specific architecture.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this JIT's specified architecture or the target architecture used to initialize this JIT.

@harlanhaskins harlanhaskins merged commit b40c63a into master Jan 11, 2017
@harlanhaskins harlanhaskins deleted the le-real-jit branch January 11, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants