Added some control-flow checks #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Jan 18, 2017
Tests/LLVMTests/IRBuilderSpec.swift
Outdated
| // CONTROLFLOW-NEXT: ret i32 1 | ||
| builder.buildRet(IntType.int32.constant(1)) | ||
|
|
||
| // CONTROLFLOW: else: |
Member
There was a problem hiding this comment.
Does this and the then block name not follow immediately?
Member
Author
There was a problem hiding this comment.
There's an empty line. Do you think I should add a
// CONTROLFLOW-NEXT:
before each of them?
Member
Author
There was a problem hiding this comment.
It would be more complete that way.
Member
Author
|
@CodaFi Good to merge? |
CodaFi
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.