Finish up the builder's instructions #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
harlanhaskins
left a comment
harlanhaskins
left a comment
There was a problem hiding this comment.
Tests? Just sanity checking.
Member
|
Otherwise LGTM! |
Sources/LLVM/IRBuilder.swift
Outdated
| /// This instruction is used to implement the `va_arg` macro in C. | ||
| /// | ||
| /// - parameter list: A value of type `va_list*` | ||
| /// - parameter type: THe type of values in the variable argument area. |
CodaFi
force-pushed
the
race-to-the-finish
branch
from
a8af497 to
fd9afe6
Compare
Member
Author
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions that are missing are the exception-handling ones. We've had a discussion off of here about the difficulty of implementing a sensible interface for them. My first attempt at this lives in #71.