[FIRRTL][CAPI] Allow constructing integers larger than 64 bits #6893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building
firrtl.constant
IRs from Chisel through MLIR,mlirIntegerAttrGet
is used to construct constants, however it only accepts aint64_t
value as an argument, so constants larger than 64 bits are not possible to be constructed at the moment.Upstream report: llvm/llvm-project#84190 (comment)
Refer to @mikeurbach's PR #6787, I propose to likewise add a string hack to workaround this problem. Using this new added C-API
firrtlAttrGetIntegerFromString
, users (e.g. Chisel) could construct aMlirIntegerAttr
from a big int string.