[binder] Support constructing integers larger than 64 bits #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
requested changes
Apr 6, 2024
sequencer
approved these changes
Apr 6, 2024
seldridge
added
the
No Release Notes
|
please rebase |
sequencer
force-pushed
the
binder-large-integer
branch
from
a930ff0
to
0e3fae8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963, upstream PR: llvm/circt#6893
This PR fixes the first problem in the issue mentioned above, for the second one, it seems to be just the style of output from CIRCT that doesn't affect the final result and there's nothing we can do about it from Chisel side.