Skip to content

Conversation

@lanza
Copy link
Member

@lanza lanza commented Oct 30, 2024

This was declared but never implemented. Upon first usage in a later
commit this fails to link.

lanza added 2 commits October 29, 2024 21:00
Created using spr 1.3.5
@lanza lanza requested a review from bcardosolopes as a code owner October 30, 2024 01:00
Copy link
Collaborator

@smeenai smeenai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches OG exactly, so LGTM

lanza added 2 commits October 30, 2024 13:08
Created using spr 1.3.5

[skip ci]
Created using spr 1.3.5
@lanza lanza changed the base branch from spr/lanza/main.circodegennfc-implement-a-missing-function to main October 30, 2024 17:08
@lanza lanza merged commit d50e440 into main Oct 30, 2024
7 checks passed
@lanza lanza deleted the spr/lanza/circodegennfc-implement-a-missing-function branch October 30, 2024 17:09
lanza added a commit that referenced this pull request Nov 5, 2024
This was declared but never implemented. Upon first usage in a later
commit this fails to link.

Reviewers: bcardosolopes, smeenai

Reviewed By: smeenai

Pull Request: #1024
lanza added a commit that referenced this pull request Mar 18, 2025
This was declared but never implemented. Upon first usage in a later
commit this fails to link.

Reviewers: bcardosolopes, smeenai

Reviewed By: smeenai

Pull Request: #1024
lanza added a commit to lanza/llvm-project that referenced this pull request Aug 11, 2025
This was declared but never implemented. Upon first usage in a later
commit this fails to link.

Reviewers: bcardosolopes, smeenai

Reviewed By: smeenai

Pull Request: llvm/clangir#1024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants