[CIR] Backport folder implementation for VecExtractOp #1613
Conversation
| // CastOp, UnaryOp and VecExtractOp are here to perform a manual `fold` in | ||
| // applyOpPatternsGreedily. |
There was a problem hiding this comment.
@bcardosolopes do you want to keep these operations in the non-canonicalized IR?
It might be possible to directly create them using OpBuilder::createOrFold in codegen which will eliminate the need to fold here. But it might be worth to be able to have unfolded version too, so I am just asking.
There was a problem hiding this comment.
@xlauko good question, I wasn't aware of createOrFold actually, neat. I guess it really depends on optimization level given we might be folding too much if we are emitting things to be statically analyzed? I don't have a concrete example though. A good answer could be: on a case basis during CIRGen if it doesn't look like affecting analysis quality?
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
AmrDeveloper
force-pushed
the
backport_vector_extract_fold
branch
from
163411a to
bf8701f
Compare
Backport #139304
3 participants
Backport #139304