[CIR][CodeGen] Emit dtor properly for objects in TernaryOp #1614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following code snippet fails with a crash:
it fails with
The crash can be traced to the construction of the TernaryOp. A yield is created and when the LexicalScope is destroyed the destructors for the object follow.
So, the CIR looks something like:
which is wrong, since the yield should come last.
The fix here is forcing a cleanup and then the yield follows. A similar rule also applies here for the "&&" case, e.g., foo(1) && foo(2) instead in the code snippet.
One more modification I made is adding a check for when the current lexScope is ternary, when creating dispatch blocks for cleanups. I believe in this case, we do not want to create a dispatch block, please correct me if I am wrong.
Finally, I add two tests to verify that everything works as intended.