Skip to content

[CIR][CIRGen][Builtin][X86] Add support for tzcnt_u16, tzcnt_u32, and tzcnt_u64 #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

[CIR][CIRGen][Builtin][X86] Add support for tzcnt_u16, tzcnt_u32, and tzcnt_u64 #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c168508
add support for X86 builtin tzcnt
ayokunle321 Jun 18, 2025
657845a
remove test with intel's variants
ayokunle321 Jun 19, 2025
6efc193
Merge branch 'main' into X86-builtin-tzcnt
ayokunle321 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,22 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned BuiltinID,
case X86::BI__builtin_ia32_lzcnt_u64: {
mlir::Value V = builder.create<cir::ConstantOp>(
getLoc(E->getExprLoc()), cir::BoolAttr::get(&getMLIRContext(), false));

return builder
.create<cir::LLVMIntrinsicCallOp>(
getLoc(E->getExprLoc()), builder.getStringAttr("ctlz"),
Ops[0].getType(), mlir::ValueRange{Ops[0], V})
.getResult();
}
case X86::BI__builtin_ia32_tzcnt_u16:
case X86::BI__builtin_ia32_tzcnt_u32:
case X86::BI__builtin_ia32_tzcnt_u64: {
mlir::Value V = builder.create<cir::ConstantOp>(
getLoc(E->getExprLoc()), cir::BoolAttr::get(&getMLIRContext(), false));
return builder
.create<cir::LLVMIntrinsicCallOp>(
getLoc(E->getExprLoc()), builder.getStringAttr("cttz"),
Ops[0].getType(), mlir::ValueRange{Ops[0], V})
.getResult();
}
}
}
32 changes: 32 additions & 0 deletions clang/test/CIR/CodeGen/X86/bmi-builtins.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// RUN: %clang_cc1 -ffreestanding -triple x86_64-unknown-linux -Wno-implicit-function-declaration -fclangir -emit-cir -o %t.cir %s
// RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s
// RUN: %clang_cc1 -ffreestanding -triple x86_64-unknown-linux -Wno-implicit-function-declaration -fclangir -emit-llvm -o %t.ll %s
// RUN: FileCheck --check-prefix=LLVM --input-file=%t.ll %s

#include <immintrin.h>

unsigned short test__tzcnt_u16(unsigned short __X) {
// CIR-LABEL: __tzcnt_u16
// LLVM-LABEL: __tzcnt_u16
return __tzcnt_u16(__X);
// CIR: {{%.*}} = cir.llvm.intrinsic "cttz" {{%.*}} : (!u16i, !cir.bool) -> !u16i
// LLVM: i16 @llvm.cttz.i16(i16 %{{.*}}, i1 false)
}

unsigned int test__tzcnt_u32(unsigned int __X) {
// CIR-LABEL: __tzcnt_u32
// LLVM-LABEL: __tzcnt_u32
return __tzcnt_u32(__X);
// CIR: {{%.*}} = cir.llvm.intrinsic "cttz" {{%.*}} : (!u32i, !cir.bool) -> !u32i
// LLVM: i32 @llvm.cttz.i32(i32 %{{.*}}, i1 false)
}

#ifdef __x86_64__
unsigned long long test__tzcnt_u64(unsigned long long __X) {
// CIR-LABEL: __tzcnt_u64
// LLVM-LABEL: __tzcnt_u64
return __tzcnt_u64(__X);
// CIR: {{%.*}} = cir.llvm.intrinsic "cttz" {{%.*}} : (!u64i, !cir.bool) -> !u64i
// LLVM: i64 @llvm.cttz.i64(i64 %{{.*}}, i1 false)
}
#endif
Loading