Skip to content

[CIR] Add support for CK_AtomicToNonAtomic casts #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: gh/lanza/3/base
Choose a base branch
from
Open

[CIR] Add support for CK_AtomicToNonAtomic casts #1989

wants to merge 9 commits into from
+45 −1

Conversation

@lanza
Copy link
Member

@lanza lanza commented Nov 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp

@lanza
Update
53208db 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
f0d0f61 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 84163bb
Pull-Request: #1989
@lanza lanza mentioned this pull request Nov 18, 2025
Open
@lanza
Update
2f37591 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
919a73d 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: b642356
Pull-Request: #1989
@lanza
Update
9e0c4b9 
[ghstack-poisoned]
@lanza lanza mentioned this pull request Nov 18, 2025
Closed
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
6d581b7 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: f250ebe
Pull-Request: #1989
@lanza
Update
fe7a360 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
ff4f920 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 0a3695b
Pull-Request: #1989
@lanza
Update
0c1570c 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
f3b7259 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 861fee0
Pull-Request: #1989
@lanza
Update
71c1db1 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
e87d139 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: a07a388
Pull-Request: #1989
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
170ac39 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: a07a388
Pull-Request: #1989
@lanza
Update
94bd65c 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
c3c1e6b 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 9e8d538
Pull-Request: #1989
@lanza
Update
ace3878 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
922a3ce 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 99fc577
Pull-Request: #1989
@lanza
Update
fd9f629 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 18, 2025
@lanza
[CIR] Add support for CK_AtomicToNonAtomic casts
ea7fc2c 
Handle implicit casts from _Atomic T to T by treating them the
same as NonAtomicToAtomic casts - just visit the subexpression.

This matches the traditional CodeGen approach and enables the
cast infrastructure for C11/C++11 _Atomic types.

Note: Full atomic load/store support remains NYI and will be
addressed in follow-up work. This commit only implements the
cast operation itself.

Test: clang/test/CIR/CodeGen/atomic-type-casts.cpp
ghstack-source-id: 7c9efcf
Pull-Request: #1989
@bcardosolopes
Copy link
Member

bcardosolopes commented Nov 18, 2025

Same nits from other PR: LLVM and OGCG missing in the testcase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

@andykaylor andykaylor Awaiting requested review from andykaylor andykaylor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lanza @bcardosolopes