-
Notifications
You must be signed in to change notification settings - Fork 183
[CIR] Add support for polymorphic typeid with vtable lookup #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lanza
wants to merge
2
commits into
gh/lanza/11/base
Choose a base branch
from
gh/lanza/11/head
base: gh/lanza/11/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+242
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
added a commit
that referenced
this pull request
Nov 23, 2025
This commit implements runtime type identification for polymorphic types, completing typeid operator support in ClangIR. Previously, only non-polymorphic (static) typeid was supported. This adds: 1. **Polymorphic typeid emission**: When typeid is applied to an expression of polymorphic class type, we now emit vtable lookup to get the runtime type_info pointer. 2. **Null pointer checking**: For pointer operands, we emit null checks and call emitBadTypeidCall (currently unreachable until exception support). Matches CodeGen behavior of always checking, even for references. 3. **Type safety checks**: emitTypeCheck ensures typeid is not used unsafely during object construction or destruction. 4. **Vtable layouts**: Supports both traditional (vtable[-1]) and relative (load.relative(vtable, -4)) layouts for Itanium ABI. Implementation follows CodeGen closely: - emitTypeidFromVTable handles the main logic with null checking - CIRGenItaniumCXXABI::emitTypeid handles ABI-specific vtable access - Uses existing getVTablePtr infrastructure - shouldTypeidBeNullChecked matches CodeGen (always returns true) The vtable layout for type_info access: - Absolute: type_info* at vtable[-1] (8 bytes before vptr) - Relative: type_info offset at vtable[-4] (4 bytes before vptr) Test Plan: - Added typeid-polymorphic.cpp with comprehensive tests - Tests verify CIR output, LLVM lowering, and CodeGen comparison (OGCG) - All 4 test cases have CIR + LLVM + OGCG checks - Covers: basic usage, references, derived classes, const pointers - Note: CIR lowering of PtrStrideOp does not emit 'inbounds' flag (general CIR lowering issue, not specific to this feature) - All CIR tests pass ghstack-source-id: b4dc46b Pull-Request: #2007
This was referenced Nov 23, 2025
lanza
added a commit
that referenced
this pull request
Nov 24, 2025
This commit implements runtime type identification for polymorphic types, completing typeid operator support in ClangIR. Previously, only non-polymorphic (static) typeid was supported. This adds: 1. **Polymorphic typeid emission**: When typeid is applied to an expression of polymorphic class type, we now emit vtable lookup to get the runtime type_info pointer. 2. **Null pointer checking**: For pointer operands, we emit null checks and call emitBadTypeidCall (currently unreachable until exception support). Matches CodeGen behavior of always checking, even for references. 3. **Type safety checks**: emitTypeCheck ensures typeid is not used unsafely during object construction or destruction. 4. **Vtable layouts**: Supports both traditional (vtable[-1]) and relative (load.relative(vtable, -4)) layouts for Itanium ABI. Implementation follows CodeGen closely: - emitTypeidFromVTable handles the main logic with null checking - CIRGenItaniumCXXABI::emitTypeid handles ABI-specific vtable access - Uses existing getVTablePtr infrastructure - shouldTypeidBeNullChecked matches CodeGen (always returns true) The vtable layout for type_info access: - Absolute: type_info* at vtable[-1] (8 bytes before vptr) - Relative: type_info offset at vtable[-4] (4 bytes before vptr) Test Plan: - Added typeid-polymorphic.cpp with comprehensive tests - Tests verify CIR output, LLVM lowering, and CodeGen comparison (OGCG) - All 4 test cases have CIR + LLVM + OGCG checks - Covers: basic usage, references, derived classes, const pointers - Note: CIR lowering of PtrStrideOp does not emit 'inbounds' flag (general CIR lowering issue, not specific to this feature) - All CIR tests pass ghstack-source-id: b4dc46b Pull-Request: #2007
This was referenced Nov 24, 2025
lanza
added a commit
that referenced
this pull request
Nov 25, 2025
This commit implements runtime type identification for polymorphic types, completing typeid operator support in ClangIR. Previously, only non-polymorphic (static) typeid was supported. This adds: 1. **Polymorphic typeid emission**: When typeid is applied to an expression of polymorphic class type, we now emit vtable lookup to get the runtime type_info pointer. 2. **Null pointer checking**: For pointer operands, we emit null checks and call emitBadTypeidCall (currently unreachable until exception support). Matches CodeGen behavior of always checking, even for references. 3. **Type safety checks**: emitTypeCheck ensures typeid is not used unsafely during object construction or destruction. 4. **Vtable layouts**: Supports both traditional (vtable[-1]) and relative (load.relative(vtable, -4)) layouts for Itanium ABI. Implementation follows CodeGen closely: - emitTypeidFromVTable handles the main logic with null checking - CIRGenItaniumCXXABI::emitTypeid handles ABI-specific vtable access - Uses existing getVTablePtr infrastructure - shouldTypeidBeNullChecked matches CodeGen (always returns true) The vtable layout for type_info access: - Absolute: type_info* at vtable[-1] (8 bytes before vptr) - Relative: type_info offset at vtable[-4] (4 bytes before vptr) Test Plan: - Added typeid-polymorphic.cpp with comprehensive tests - Tests verify CIR output, LLVM lowering, and CodeGen comparison (OGCG) - All 4 test cases have CIR + LLVM + OGCG checks - Covers: basic usage, references, derived classes, const pointers - Note: CIR lowering of PtrStrideOp does not emit 'inbounds' flag (general CIR lowering issue, not specific to this feature) - All CIR tests pass ghstack-source-id: b4dc46b Pull-Request: #2007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This commit implements runtime type identification for polymorphic types,
completing typeid operator support in ClangIR.
Previously, only non-polymorphic (static) typeid was supported. This adds:
Polymorphic typeid emission: When typeid is applied to an expression
of polymorphic class type, we now emit vtable lookup to get the runtime
type_info pointer.
Null pointer checking: For pointer operands, we emit null checks and
call emitBadTypeidCall (currently unreachable until exception support).
Matches CodeGen behavior of always checking, even for references.
Type safety checks: emitTypeCheck ensures typeid is not used unsafely
during object construction or destruction.
Vtable layouts: Supports both traditional (vtable[-1]) and relative
(load.relative(vtable, -4)) layouts for Itanium ABI.
Implementation follows CodeGen closely:
The vtable layout for type_info access:
Test Plan:
(general CIR lowering issue, not specific to this feature)