[CIR] Lower element-wise shift operations for OpenCL #2019
Merged
+107
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement OpenCL 6.3j shift semantics for both left and right shifts in CIR. The shift amount is now masked by the bit width of the LHS operand, handling both scalar and vector RHS operands.
mahmood82
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Contributor
Author
|
This seems to be ready. Could someone with commit access please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement OpenCL 6.3j shift semantics for both left and right shifts in CIR. The shift amount is now masked by the bit width of the LHS operand, handling both scalar and vector RHS operands.