[CIR] Emit C++ runtime variables as constants instead of globals #2025
+32
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
requested review from
andykaylor,
bcardosolopes and
xlauko
as code owners
lanza
added a commit
that referenced
this pull request
Nov 26, 2025
VTables, typeinfo, typeinfo names, and VTTs should be immutable constants placed in read-only memory, not mutable globals. This aligns CIR behavior with CodeGen and prevents security issues related to writable vtables. The fix adds the `isConstant=true` parameter to createGlobalOp when creating C++ runtime variables in createOrReplaceCXXRuntimeVariable(). ghstack-source-id: 24e82e3 Pull-Request: #2025
lanza
added a commit
that referenced
this pull request
Nov 27, 2025
VTables, typeinfo, typeinfo names, and VTTs should be immutable constants placed in read-only memory, not mutable globals. This aligns CIR behavior with CodeGen and prevents security issues related to writable vtables. The fix adds the `isConstant=true` parameter to createGlobalOp when creating C++ runtime variables in createOrReplaceCXXRuntimeVariable(). ghstack-source-id: 24e82e3 Pull-Request: #2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
VTables, typeinfo, typeinfo names, and VTTs should be immutable constants
placed in read-only memory, not mutable globals. This aligns CIR behavior
with CodeGen and prevents security issues related to writable vtables.
The fix adds the
isConstant=trueparameter to createGlobalOp when creatingC++ runtime variables in createOrReplaceCXXRuntimeVariable().