Skip to content

Conversation

@lukel97
Copy link
Contributor

@lukel97 lukel97 commented Nov 17, 2025

This was changed in 1b1c1e9 from lnt -> lnt.db, but it broke our Igalia instance which uses this docker compose file.

All the old test results disappeared because we're now reading + writing from a different db.

This changes it back to the original. Not sure if other downstream users were affected

@lukel97 lukel97 requested a review from ldionne November 17, 2025 12:08
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the old test results disappeared because we're now reading + writing from a different db.

Did you actually lose the old DB? If so, that sucks, sorry about that. I do think we shouldn't be pulling the latest Docker image on each commit without any manual verification or at least a robust solution for database persistence. It's pretty bad to lose historical data just because something like this slipped past.

@lukel97
Copy link
Contributor Author

lukel97 commented Nov 18, 2025

Don't worry the data is still all there in the old DB, I also didn't notice the name change when reviewing that PR. FWIW we are manually checking and pulling in the new docker-compose.ymls, but the diff is obscured because of all the recent work going on there. Not that I'm complaining, move fast and break things etc :)

@lukel97 lukel97 merged commit 4edc628 into llvm:main Nov 18, 2025
15 checks passed
@ldionne
Copy link
Member

ldionne commented Nov 19, 2025

Don't worry the data is still all there in the old DB

Oooof, I got scared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants