PR for llvm/llvm-project#58205 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@mgorny What do you think about merging this PR to the release branch? |
Member
|
I like it but I think @petrhosek should decide ;-). |
Add LLVM_ENABLE_ZSTD to llvm_canonicalize_cmake_booleans(). This is needed to ensure that the substitutions in lit.site.cfg.py resolve to correct Python booleans. Differential Revision: https://reviews.llvm.org/D135357 (cherry picked from commit bc4bcbc)
This module is used to find the system zstd library. The imported targets intentionally use the same name as the generate zstd config CMake file so these can be used interchangeably. Differential Revision: https://reviews.llvm.org/D134990 (cherry picked from commit 2d4fd0b)
llvmbot
force-pushed
the
llvm-issue58205
branch
from
c6de6de to
5915b6e
Compare
Member
|
Ok, now I've got both commits. I approve of my part, leaving the other part for @petrhosek to approve. |
Contributor
|
This patch looks fine to me, and I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#58205