Skip to content

Commit 02c043e

Browse files
committed
Fix review comments
1 parent 206e875 commit 02c043e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -988,7 +988,7 @@ def request_writeMemory(self, memoryReference, data, offset=0, allowPartial=Fals
988988
return self._send_recv(command_dict)
989989

990990
def request_evaluate(
991-
self, expression, frameIndex=0, threadId=None, context=None, is_hex=None
991+
self, expression, frameIndex=0, threadId=None, context=None, is_hex: bool = None
992992
):
993993
stackFrame = self.get_stackFrame(frameIndex=frameIndex, threadId=threadId)
994994
if stackFrame is None:

lldb/tools/lldb-dap/Handler/EvaluateRequestHandler.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,7 @@ EvaluateRequestHandler::Run(const EvaluateArguments &arguments) const {
8484
if (value.GetError().Fail())
8585
return ToError(value.GetError(), /*show_user=*/false);
8686

87-
bool hex = false;
88-
if (arguments.format)
89-
hex = arguments.format->hex;
87+
const bool hex = arguments.format ? arguments.format->hex : false;
9088

9189
VariableDescription desc(value, dap.configuration.enableAutoVariableSummaries,
9290
hex);

0 commit comments

Comments
 (0)