Skip to content

Commit 663d2e1

Browse files
committed
Apply comments: made the API non-move-only
1 parent 7183afa commit 663d2e1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

offload/plugins-nextgen/common/include/PluginInterface.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ struct InfoTreeNode {
192192
llvm::DenseMap<DeviceInfo, size_t> DeviceInfoMap;
193193

194194
InfoTreeNode() : InfoTreeNode("", std::monostate{}, "") {}
195-
InfoTreeNode(std::string &&Key, VariantType Value, std::string &&Units)
195+
InfoTreeNode(std::string Key, VariantType Value, std::string Units)
196196
: Key(std::move(Key)), Value(Value), Units(std::move(Units)) {}
197197

198198
/// Add a new info entry as a child of this node. The entry requires at least
@@ -201,7 +201,8 @@ struct InfoTreeNode {
201201
/// and must be a string. Providing a device info key allows liboffload to
202202
/// use that value for an appropriate olGetDeviceInfo query
203203
template <typename T = std::monostate>
204-
InfoTreeNode *add(std::string &&Key, T Value = T(), std::string &&Units = "",
204+
InfoTreeNode *add(std::string Key, T Value = T(),
205+
std::string Units = std::string(),
205206
std::optional<DeviceInfo> DeviceInfoKey = std::nullopt) {
206207
assert(!Key.empty() && "Invalid info key");
207208

0 commit comments

Comments
 (0)