[NFC][LLVM] Override and deprecate raw_string_ostream::flush

Author: jurahul

llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h

@@ -1813,7 +1813,6 @@ struct BFIDOTGraphTraitsBase : public DefaultDOTGraphTraits {
 
     raw_string_ostream OS(Result);
     OS << "color=\"red\"";
-    OS.flush();
     return Result;
   }
 
@@ -1872,8 +1871,6 @@ struct BFIDOTGraphTraitsBase : public DefaultDOTGraphTraits {
         OS << ",color=\"red\"";
       }
     }
-
-    OS.flush();
     return Str;
   }
 };

llvm/include/llvm/Analysis/LazyCallGraph.h

@@ -513,7 +513,6 @@ class LazyCallGraph {
       std::string Name;
       raw_string_ostream OS(Name);
       OS << *this;
-      OS.flush();
       return Name;
     }
   };
@@ -654,7 +653,6 @@ class LazyCallGraph {
       std::string Name;
       raw_string_ostream OS(Name);
       OS << *this;
-      OS.flush();
       return Name;
     }
 

llvm/include/llvm/Support/FormatVariadic.h

@@ -105,7 +105,6 @@ class formatv_object_base {
     std::string Result;
     raw_string_ostream Stream(Result);
     Stream << *this;
-    Stream.flush();
     return Result;
   }
 

llvm/include/llvm/Support/InterleavedRange.h

@@ -56,7 +56,6 @@ template <typename Range> class InterleavedRange {
     std::string Result;
     raw_string_ostream Stream(Result);
     Stream << *this;
-    Stream.flush();
     return Result;
   }
 

llvm/include/llvm/Support/raw_ostream.h

@@ -682,6 +682,9 @@ class LLVM_ABI raw_string_ostream : public raw_ostream {
   void reserveExtraSpace(uint64_t ExtraSize) override {
     OS.reserve(tell() + ExtraSize);
   }
+
+  LLVM_DEPRECATED("flush() for raw_string_ostream does nothing", "remove it")
+  void flush() {}
 };
 
 /// A raw_ostream that writes to an SmallVector or SmallString.  This is a

llvm/lib/Analysis/ImportedFunctionsInliningStatistics.cpp

@@ -167,7 +167,6 @@ void ImportedFunctionsInliningStatistics::dump(const bool Verbose) {
                  "non-imported functions inlined into importing module",
                  InlinedNotImportedFunctionsToImportingModuleCount,
                  NotImportedFuncCount, "non-imported functions");
-  Ostream.flush();
   dbgs() << Out;
 }
 

llvm/lib/CodeGen/MIRCanonicalizerPass.cpp

@@ -96,7 +96,6 @@ rescheduleLexographically(std::vector<MachineInstr *> instructions,
     std::string S;
     raw_string_ostream OS(S);
     II->print(OS);
-    OS.flush();
 
     // Trim the assignment, or start from the beginning in the case of a store.
     const size_t i = S.find('=');

llvm/lib/CodeGen/MachineBlockPlacement.cpp

@@ -700,7 +700,6 @@ static std::string getBlockName(const MachineBasicBlock *BB) {
   raw_string_ostream OS(Result);
   OS << printMBBReference(*BB);
   OS << " ('" << BB->getName() << "')";
-  OS.flush();
   return Result;
 }
 #endif

llvm/lib/CodeGen/ModuloSchedule.cpp

@@ -2033,7 +2033,6 @@ void PeelingModuloScheduleExpander::validateAgainstModuloScheduleExpander() {
   std::string ScheduleDump;
   raw_string_ostream OS(ScheduleDump);
   Schedule.print(OS);
-  OS.flush();
 
   // First, run the normal ModuleScheduleExpander. We don't support any
   // InstrChanges.

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

@@ -1953,7 +1953,6 @@ void TargetLoweringObjectFileCOFF::emitLinkerDirectives(
     raw_string_ostream OS(Flags);
     emitLinkerFlagsForGlobalCOFF(OS, &GV, getContext().getTargetTriple(),
                                  getMangler());
-    OS.flush();
     if (!Flags.empty()) {
       Streamer.switchSection(getDrectveSection());
       Streamer.emitBytes(Flags);
@@ -1978,7 +1977,6 @@ void TargetLoweringObjectFileCOFF::emitLinkerDirectives(
         raw_string_ostream OS(Flags);
         emitLinkerFlagsForUsedCOFF(OS, GV, getContext().getTargetTriple(),
                                    getMangler());
-        OS.flush();
 
         if (!Flags.empty()) {
           Streamer.switchSection(getDrectveSection());