Skip to content

Commit 902614d

Browse files
DamonFoolMaskRay
authored andcommitted
[docs] TestingGuide.rst: Fix incorrect description
This patch fixes two incorrect descriptions in TestingGuide.rst. 1. test/lit.site.cfg --> test/lit.site.cfg.py After https://reviews.llvm.org/D37838 , the `test/lit.site.cfg` had been added a .py extension. So it should be `test/lit.site.cfg.py`. 2. $(LLVM_OBJ_ROOT)/$(BuildMode)/bin --> $(LLVM_OBJ_ROOT)/bin The current build system doesn't create a $(BuildMode) directory any more. So it should be removed. Reviewed By: mehdi_amini, MaskRay Differential Revision: https://reviews.llvm.org/D140780
1 parent 4d3f26b commit 902614d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

llvm/docs/TestingGuide.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ Writing new regression tests
206206

207207
The regression test structure is very simple, but does require some
208208
information to be set. This information is gathered via ``cmake``
209-
and is written to a file, ``test/lit.site.cfg`` in the build directory.
209+
and is written to a file, ``test/lit.site.cfg.py`` in the build directory.
210210
The ``llvm/test`` Makefile does this work for you.
211211

212212
In order for the regression tests to work, each directory of tests must
@@ -235,7 +235,7 @@ as many RUN lines as needed.
235235

236236
:program:`lit` performs substitution on each RUN line to replace LLVM tool names
237237
with the full paths to the executable built for each tool (in
238-
``$(LLVM_OBJ_ROOT)/$(BuildMode)/bin)``. This ensures that :program:`lit` does
238+
``$(LLVM_OBJ_ROOT)/bin``). This ensures that :program:`lit` does
239239
not invoke any stray LLVM tools in the user's path during testing.
240240

241241
Each RUN line is executed on its own, distinct from other lines unless

0 commit comments

Comments
 (0)