many tests fail if the shell does not support "set -o pipefail"

[llvmbot]

Bugzilla Link	9687
Version	trunk
OS	Windows 2000
Blocks	llvm/llvm-bugzilla-archive#9703
Attachments	Patch to avoid using "set -o pipefail" when not supported
Reporter	LLVM Bugzilla Contributor
CC	@emaste,@modocache,@ZviRackover

Extended Description

My platform is: Developer Studio 2008 (MSVC 9), CMake generating NMake makefiles, MKS 9.
MKS provides unix-like command line tools, though many provide only very basic compatibility.

When CMake configures the tree, all the test scripts begin with "set -o pipefail".

Unfortunately MKS bash doesn't understand the pipefail option:

D:\llvmtrunk\llvm\utils>which bash
c:/mks/mksnt/bash.exe

D:\llvmtrunk\llvm\utils>bash -c "set -o pipefail"
set: Unknown option "pipefail"

I'm attaching a patch to work around this limitation.

Tested on:

• LLVM trunk Windows + Cmake + MKS + NMake makefiles
• LLVM 2.8 Linux (with recent GNU batsh)

[llvmbot]

I didn't know MKS.
BTW, does MKS provide its own python?

[llvmbot]

I didn't know MKS.
BTW, does MKS provide its own python?

I'm using MKS 9, which might be old. I'm using it because it's our corporate standard for providing unix-like tools under Windows, at least for now.

I do not recommend it because its implementations are very old and so they have many inconsistencies with GNU tools. Besides, MKS is proprietary software and they charge a lot for it.
The one upside of MKS is that the commands tend to be faster than MSYS, and that makes a difference for some environments like ours.

[ZviRackover]

FYI, I see the same issue happen with a fairly recent version of Cygwin.

bash.exe --version
GNU bash, version 4.1.10(4)-release (i686-pc-cygwin)

Created an attachment (id=6441) [details]
Patch to avoid using "set -o pipefail" when not supported

My platform is: Developer Studio 2008 (MSVC 9), CMake generating NMake
makefiles, MKS 9.
MKS provides unix-like command line tools, though many provide only very basic
compatibility.

When CMake configures the tree, all the test scripts begin with "set -o
pipefail".

Unfortunately MKS bash doesn't understand the pipefail option:

D:\llvmtrunk\llvm\utils>which bash
c:/mks/mksnt/bash.exe

D:\llvmtrunk\llvm\utils>bash -c "set -o pipefail"
set: Unknown option "pipefail"

I'm attaching a patch to work around this limitation.

Tested on:

• LLVM trunk Windows + Cmake + MKS + NMake makefiles
• LLVM 2.8 Linux (with recent GNU batsh)

[llvmbot]

FYI, I see the same issue happen with a fairly recent version of Cygwin.

bash.exe --version
GNU bash, version 4.1.10(4)-release (i686-pc-cygwin)

I have not met the issue on cygwin-1.7.

$ bash --version
GNU bash, version 4.1.10(4)-release (i686-pc-cygwin)

[emaste]

Updated title as this affects other shells too, including the standard /bin/sh on FreeBSD.

[llvmbot]

LLVM tests (lit) started to fail for me due to "set -o pipefail" breakage.

I use LLVM SVN r.307534 (LLVM 5.0.0svn).
NetBSD 8.99.1

$ what /netbsd
/netbsd
NetBSD 8.99.1 (GENERIC) #​8: Mon Jul 10 00:36:35 CEST 2017

For some reason this problem reappeared only lately for me.

I see a lot of reports like:

---

Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70..
FAIL: LLVM :: Transforms/DeadStoreElimination/free.ll (17073 of 21225)
******************** TEST 'LLVM :: Transforms/DeadStoreElimination/free.ll' FAILED ********************
Script:

/public/pkgsrc-tmp/wip/llvm-netbsd/work/build/./bin/opt < /public/pkgsrc-tmp/wip/llvm-netbsd/work/llvm/test/Transforms/DeadStoreElimination/free.ll -basicaa -dse -S | /public/pkgsrc-tmp/wip/llvm-netbsd/work/build/./bin/FileCheck /public/pkgsrc-tmp/wip/llvm-netbsd/work/llvm/test/Transforms/DeadStoreElimination/free.ll

Exit Code: 2

Command Output (stderr):

set: Illegal option -o pipefail

--

This breaks thousands of LLVM tests. I use regular NetBSD shell under /bin/sh.

[llvmbot]

mentioned in issue llvm/llvm-bugzilla-archive#9703