LLVM miscompiles Wine's dlls/user32/dialog.c

[llvmbot]

Bugzilla Link	9707
Resolution	FIXED
Resolved on	Aug 02, 2013 19:19
Version	trunk
OS	All
Blocks	llvm/llvm-bugzilla-archive#10638
Reporter	LLVM Bugzilla Contributor

Extended Description

Part 5 of a long series filed on behalf of Austin English. (I hope you're not tired of me at this point...)

Clang is also miscompiling the Dialog Manager code (dlls/user32/dialog.c) from Wine. This one's weird. It's not crashing, but it locks up and produces no output whatsoever. Valgrind reports an invalid 4-byte read inside the Dialog Manager, so this might have something to do with it. Not sure if it's optimizer related, but it's probably not integrated-assembler-related.

[llvmbot]

dialog.i
Occurs with/without integrated assembler, and at -O0 and -O2.

clang -E -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -std=gnu89 -g -O0 dialog.c &> dialog.i

dialog.i attached.

[llvmbot]

preprocessed gcc file
gcc -E -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -std=gnu89 -g -O0 dialog.c &> ~/dialog_gcc.i

gcc (Gentoo 4.4.5 p1.2, pie-0.4.5) 4.4.5

[llvmbot]

Actually, this is probably a dupe of bug 9704 (or at least related).

[llvmbot]

Still present, as of
git-svn-id: http://llvm.org/svn/llvm-project/llvm/trunk@150433 91177308-0d34-0410-b5e6-96231b3b80d8

and wine-1.4-rc3-23-gd548af4. Not a stack alignment issue, the wine patch from bug 9830 does not help here.

[llvmbot]

Still in svn.

[llvmbot]

Works fine in wine-1.4 and current wine from git (wine-1.5.19-186-g1cd0c4a).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@170295 91177308-0d3
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@170294 91177308-0d34

[llvmbot]

FWIW, this is still in:
Apple clang version 3.1 (tags/Apple/clang-318.0.61) (based on LLVM 3.1svn)
Target: x86_64-apple-darwin11.4.2
Thread model: posix

so it was fixed some time after that.