Clang Does Not Supply Correct Linker Flags Under Slackware

[llvmbot]

Bugzilla Link	9731
Resolution	FIXED
Resolved on	Aug 14, 2011 02:58
Version	trunk
OS	Linux
Attachments	Minimal solution diff
Reporter	LLVM Bugzilla Contributor
CC	@tkremenek

Extended Description

To Reproduce:
Attempt to link together files with most recent clang version on Slackware.

Results:
/usr/bin/ld: cannot find crt1.o: No such file or directory
/usr/bin/ld: cannot find crti.o: No such file or directory
/usr/bin/ld: cannot find crtbegin.o: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Fix:
ToolChains.cpp must have the path added for the Slackware gcc directory.
See attached diff for minimal fix for C linking under Slackware.

Note:
Based upon how the function for identifying the GccTripple, it seems as though it would be more logical and portable to find the /??/gcc/ folder and assume that the folder nested inside of it is the GccTripple.
This may be invalid in some special cases, but it appears to be much more general than the current approach.

[tkremenek]

I committed this patch in r129704.

I agree that searching for /??/gcc may be more flexible, although there are advantages to explicitly enumerating (some cases) so that the behavior is well-defined. I think the design of this functionality is worth bringing up on cfe-dev. I personally don't have a strong opinion.

[llvmbot]

Path fix for Slackware64
Slackware64 has same issue, but needs the 64bit path added (for using 64bit triple). Attached is patch adding this path, in same manner as original patch above.