API: isAllOnesValue and getAllOnesValue are not defined for all types

[llvmbot]

Bugzilla Link	10717
Resolution	FIXED
Resolved on	Aug 24, 2011 23:44
Version	trunk
OS	Windows NT
Reporter	LLVM Bugzilla Contributor

Extended Description

We can't use the following API because it is not implemented for all types:

if (C->isAllOnesValue())
return Constant::getAllOnesValue(DestTy);

I plan to implement this at some point.

[llvmbot]

What's the plan for an all-ones-value for ConstantStruct?

[llvmbot]

The same as all zeros.

[llvmbot]

A new IR magic value?? Why is this that important?

[llvmbot]

In my experience it is the most common useful value after zero.
Constant::getAllOnesValue already exists, it's just not uniform: it supports
a random range of types. It might as well be boosted up to handle everything.
If getAllOnesValue exists then so should isAllOnesValue.

[llvmbot]

I've implemented the is/getAllOnes for ConstantInt/ConstantFP/ConstantVector.
I am writing some tests and will send a patch tomorrow.

[llvmbot]

A patch to add getallones

[lattner]

If this got committed, please close this bug.