Double single-quotes in "illegal vector component name" diagnostic

[tbaederr]

See this test case:

llvm-project/clang/test/SemaCXX/vector-bool.cpp

Lines 88 to 91 in 565a9ac

	eight_bools.y = false; // expected-error@88 {{illegal vector component name ''y''}}
	&eight_bools.z; // expected-error@89 {{illegal vector component name ''z''}}
	foo(eight_bools.w); // expected-error@90 {{illegal vector component name ''w''}}
	foo(eight_bools.wyx); // expected-error@91 {{illegal vector component name ''wyx''}}

The double single-quotes are incorrect and usually coming from the diagnostic text containing the quotes directly, while passing a NamedDecl to the diagnostics engine adds single-quotes again.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Timm Baeder (tbaederr)

See this test case: https://github.com/llvm/llvm-project/blob/565a9ac7df3815ed038938942be4cf1471de4755/clang/test/SemaCXX/vector-bool.cpp#L88-L91

The double single-quotes are incorrect and usually coming from the diagnostic text containing the quotes directly, while passing a NamedDecl to the diagnostics engine adds single-quotes again.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Timm Baeder (tbaederr)

See this test case: https://github.com/llvm/llvm-project/blob/565a9ac7df3815ed038938942be4cf1471de4755/clang/test/SemaCXX/vector-bool.cpp#L88-L91

The double single-quotes are incorrect and usually coming from the diagnostic text containing the quotes directly, while passing a NamedDecl to the diagnostics engine adds single-quotes again.

[smallp-o-p]

I'll try and tackle this. Could I be assigned this issue? Thanks!

[charan-003]

can i also work on this

[tbaederr]

Only one person can work on an issue at a time.