[clang-tidy] Incorrect suggestion for readability-simplify-boolean-expr

[ChuanqiXu9]

Reproducer: https://godbolt.org/z/cKfnavMvb

#include <string>
#include <iostream>
struct Foo {
    std::string appName;
    int maxCopy;
};

int main()
{
    std::string app;
    Foo fileMeta;
    int maxCopy;
    bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
}

clang-tidy shows:

<source>:13:10: warning: Value stored to 'x' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<source>:13:10: note: Value stored to 'x' during its initialization is never read
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<source>:13:14: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |              !                         ||         !=
2 warnings generated.

But it should be app != fileMeta.appName || maxCopy != fileMeta.maxCopy)

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Chuanqi Xu (ChuanqiXu9)

Reproducer: https://godbolt.org/z/cKfnavMvb

#include <string>
#include <iostream>
struct Foo {
    std::string appName;
    int maxCopy;
};

int main()
{
    std::string app;
    Foo fileMeta;
    int maxCopy;
    bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
}

clang-tidy shows:

<source>:13:10: warning: Value stored to 'x' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<source>:13:10: note: Value stored to 'x' during its initialization is never read
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<source>:13:14: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
   13 |     bool x = !(app == fileMeta.appName && maxCopy == fileMeta.maxCopy);
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |              !                         ||         !=
2 warnings generated.

But it should be app != fileMeta.appName || maxCopy != fileMeta.maxCopy)

[chrchr-github]

Standalone:

struct T {};
bool operator==(const T&, const T&);

bool f(const T& t1, const T& t2, int i, int j) {
    return !(t1 == t2 && i == j);
}

https://godbolt.org/z/drG3YfKrf