[clang-tidy] Check request: readability-avoid-yoda-conditions

[carlosgalvezp]

It would be good to have a check that converts yoda conditions into normal conditions, as read into plain English from left to right.

Example:

if (0 == foo())
{}

should be converted into:

if (foo() == 0)
{}

In 2025, accidental assignments should no longer be a thing, tools have caught up. Compilers warn about it via -Wparentheses, active by default in Clang and via -Wall in GCC.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Carlos Galvez (carlosgalvezp)

It would be good to have a check that converts [yoda conditions](https://en.wikipedia.org/wiki/Yoda_conditions) into normal conditions, as read into plain English from left to right.

Example:

if (0 == foo())
{}

should be converted into:

if (foo() == 0)
{}

In 2025, accidental assignments should no longer be a thing, tools have caught up. Compilers warn about it via -Wparentheses, active by default in Clang and via -Wall in GCC.

[vbvictor]

I guess we should not warn on cases like if ((3.14 < y) && (y <= 42)).
As first iteration we can only check if if-statement has single condition operator with a number on LHS and functionCall/variable on RHS.

Seems like an easy check, should be make it good first issue?

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Carlos Galvez (carlosgalvezp)

It would be good to have a check that converts [yoda conditions](https://en.wikipedia.org/wiki/Yoda_conditions) into normal conditions, as read into plain English from left to right.

Example:

if (0 == foo())
{}

should be converted into:

if (foo() == 0)
{}

In 2025, accidental assignments should no longer be a thing, tools have caught up. Compilers warn about it via -Wparentheses, active by default in Clang and via -Wall in GCC.

[vbvictor]

To work with clang-tidy, please read https://clang.llvm.org/extra/clang-tidy/Contributing.html and see how other checks are implemented (use clang-tidy tag on github)

[sreevyshnavi02]

Hello, I would like to work on this. Could you please assign it to me?