Cannot run make test: ERROR: tcl error sourcing /home/edwin/llvm-svn/llvm/test/site.exp

[edwintorok]

Bugzilla Link	2183
Resolution	FIXED
Resolved on	Mar 31, 2008 11:51
Version	unspecified
OS	Linux
Attachments	patch to avoid double quotes in site.exp

Extended Description

On Linux x86-64 I cannot run make check, same on 32-bit.
On x86-64 I have ocamlc installed, on 32-bit I don't. Yet it fails on both.

tclsh is 8.5, but I also have 8.4 installed.

edwin@lightspeed2:~/llvm-svn/llvm$ make check
llvm[0]: Running test suite
make[1]: Entering directory `/home/edwin/llvm-svn/llvm/test'
Making a new site.exp file...
( ulimit -t 600 ; ulimit -d 512000 ;
PATH="/home/edwin/llvm-svn/llvm/Release/bin:/home/edwin/llvm-svn/llvm/test/Scripts:/usr/lib/ccache:/home/edwin/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games"
/usr/bin/runtest --ignore "llvm2cpp.exp" )
ERROR: tcl error sourcing /home/edwin/llvm-svn/llvm/test/site.exp.
extra characters after close-quote
while executing
"set ocamlc ""/usr/bin/ocamlc.opt" -cc g++ -I /home/edwin/llvm-svn/llvm/Release/lib/ocaml"

All variables above are generated by configure. Do Not Ed..."

(file "/home/edwin/llvm-svn/llvm/test/site.exp" line 24)
invoked from within

"source /home/edwin/llvm-svn/llvm/test/site.exp"
("uplevel" body line 1)
invoked from within
"uplevel #​0 source /home/edwin/llvm-svn/llvm/test/site.exp"
invoked from within
"catch "uplevel #​0 source $file""
make[1]: *** [check-local] Error 1
make[1]: Leaving directory `/home/edwin/llvm-svn/llvm/test'
make: *** [check] Error 2

[edwintorok]

"set ocamlc ""/usr/bin/ocamlc.opt" -cc g++ -I

I was getting double quotes there, because OCAMLC was quoted itself.

This patch fixes it, but there was probably a good reason to quote in the first place, so please check that it doesn't break elsewhere:
http://llvm.org/bugs/attachment.cgi?id=1561

[llvmbot]

I've reverted Erick's patch until a more thoroughly tested version is available. Do not install ocaml on a path with spaces.

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080331/060443.html

LLVM's makefiles (as with most makefiles) do not support spaces in pathnames. This is unfortunate, but I don't think that fixing it is realistic due to 'make's limitations.