Some tests generate GCC warnings

[matthijskooijman]

Bugzilla Link	2452
Resolution	FIXED
Resolved on	Jun 20, 2008 12:23
Version	trunk
OS	Linux

Extended Description

There are some tests that are generating GCC warnings, which until recently were ignored. Now, stderr output from a test program is cause for failure. Preferably these warnings should be fixed, but possibly they also mean that the test is not working properly. Someone who knows details about these tests should have a look.

It concerns the following tests:

FAIL: /home/kooijman/src/llvm-trunk/test/FrontendC/2003-08-21-WideString.c
Failed with unknown error (or has stderr output) at line 1
while running: /home/kooijman/src/llvm-gcc/install/bin/llvm-gcc -emit-llvm -S /home/kooijman/src/llvm-trunk/test/FrontendC/2003-08-21-WideString.c -o - | llvm-as -f -o /dev/null

/home/kooijman/src/llvm-trunk/test/FrontendC/2003-08-21-WideString.c:5: warning: initialization from incompatible pointer type

FAIL: /home/kooijman/src/llvm-trunk/test/FrontendC/2004-02-13-IllegalVararg.c
Failed with unknown error (or has stderr output) at line 1
while running: /home/kooijman/src/llvm-gcc/install/bin/llvm-gcc -emit-llvm -xc /home/kooijman/src/llvm-trunk/test/FrontendC/2004-02-13-IllegalVararg.c -w -c -o - | llc

/home/kooijman/src/llvm-trunk/test/FrontendC/2004-02-13-IllegalVararg.c: In function ‘test’:
/home/kooijman/src/llvm-trunk/test/FrontendC/2004-02-13-IllegalVararg.c:9: note: if this code is reached, the program will abort

FAIL: /home/kooijman/src/llvm-trunk/test/FrontendC/2006-09-18-fwrite-cast-crash.c for #1282
Failed with unknown error (or has stderr output) at line 1
while running: /home/kooijman/src/llvm-gcc/install/bin/llvm-gcc -emit-llvm /home/kooijman/src/llvm-trunk/test/FrontendC/2006-09-18-fwrite-cast-crash.c -S -o /dev/null

/home/kooijman/src/llvm-trunk/test/FrontendC/2006-09-18-fwrite-cast-crash.c: In function ‘Usage’:
/home/kooijman/src/llvm-trunk/test/FrontendC/2006-09-18-fwrite-cast-crash.c:11: warning: function called through a non-compatible type
/home/kooijman/src/llvm-trunk/test/FrontendC/2006-09-18-fwrite-cast-crash.c:11: note: if this code is reached, the program will abort

FAIL: /home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-05-ConstCtor.c for #2013
Failed with unknown error (or has stderr output) at line 1
while running: /home/kooijman/src/llvm-gcc/install/bin/llvm-gcc -emit-llvm -xc -Os -c /home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-05-ConstCtor.c -o /dev/null

/home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-05-ConstCtor.c:11:30: warning: multi-character character constant

FAIL: /home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-28-PackedUnionMember.c
Failed with unknown error (or has stderr output) at line 1
while running: /home/kooijman/src/llvm-gcc/install/bin/llvm-gcc -emit-llvm /home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-28-PackedUnionMember.c -S -o -

declare i32 @​bork(i32 (...), %struct.E)
/home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-28-PackedUnionMember.c:28:23: warning: multi-character character constant
/home/kooijman/src/llvm-trunk/test/FrontendC/2007-09-28-PackedUnionMember.c:33:7: warning: multi-character character constant

I've XFAIL'd these test for now.

[llvmbot]

Code that gives warnings is acceptable to llvm-gcc, which means it should be acceptable in the test suite; we need to be able to have tests for such code. Code that gives warnings is more than usually likely to be code that stresses compilers, so this is fairly important.

I wouldn't mind if the test had to do something explicit to say "warnings are expected here".

The 2nd and 3rd cases you list produce a warning that -w does not suppress. (This is actually a "note" in gcc's internal terminology, not a "warning"; that's why. There should be some way to suppress "notes" but I couldn't find it.)

The 1st, 4th and 5th cases do not fail on Darwin x86-32, so one possibility is to make them target that environment; I'll see if that looks appropriate.

[llvmbot]

Given Chris' comment on the mailing list I am not going to change any more tests.
However, I think it would be appropriate to change 2003-08-21-WideString.c to use wchar_t.
The other 2 are warning about multiple-character character constants; this is something Apple has to accept without warnings for historical reasons, but I doubt we want to disable the warnings in other environments.

[lattner]

what is required to close this?

[lattner]

The remaining 3 xpass's should be fixed now.

[llvmbot]

On x86-64 there are still a ton of these:

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-02-14-EntryNodePreds.c
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm -S /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-02-14-EntryNodePreds.c -o - | llvm-as -f -o /dev/null
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-02-14-EntryNodePreds.c: In function ‘do_merge’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-02-14-EntryNodePreds.c:33: warning: cast from pointer to integer of different size

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-07-14-MiscListTests.c
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm -S /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-07-14-MiscListTests.c -o - | llvm-as -f -o /dev/null
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2002-07-14-MiscListTests.c:5: warning: conflicting types for built-in function ‘malloc’

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2003-08-21-BinOp-Type-Mismatch.c
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm -S /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2003-08-21-BinOp-Type-Mismatch.c -o - | llvm-as -f -o /dev/null
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2003-08-21-BinOp-Type-Mismatch.c: In function ‘foo’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2003-08-21-BinOp-Type-Mismatch.c:8: warning: cast to pointer from integer of different size
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2003-08-21-BinOp-Type-Mismatch.c:8: warning: cast to pointer from integer of different size

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c for #859
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c -S -o -
; ModuleID = '/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"
@​i23.1441 = internal global i32 4 ; <i32*> [#uses=1]
@​i = global i32 4 ; <i32*> [#uses=0]
@​Arr = common global [100 x i32] zeroinitializer, align 32 ; <[100 x i32]*> [#uses=3]

define i32 @​test() nounwind {
entry:
%retval = alloca i32 ; <i32*> [#uses=2]
%tmp = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
%tmp1 = load i32* @​i23.1441, align 4 ; [#uses=1]
store i32 %tmp1, i32* %tmp, align 4
%tmp2 = load i32* %tmp, align 4 ; [#uses=1]
store i32 %tmp2, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval3 = load i32* %retval ; [#uses=1]
ret i32 %retval3
}

define i32 @​foo(i32 %i) nounwind {
entry:
%i_addr = alloca i32 ; <i32*> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%tmp = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 %i, i32* %i_addr
%tmp1 = call i32 (...)* @​bar( i32* getelementptr ([100 x i32]* @​Arr, i32 0, i64 49) ) nounwind ; [#uses=1]
%tmp3 = load i32* %i_addr, align 4 ; [#uses=1]
%tmp345 = sext i32 %tmp3 to i64 ; [#uses=1]
%tmp6 = getelementptr [100 x i32]* @​Arr, i32 0, i64 %tmp345 ; <i32*> [#uses=1]
%tmp8 = call i32 (...)* @​bar( i32* %tmp6 ) nounwind ; [#uses=1]
%tmp10 = add i32 %tmp1, %tmp8 ; [#uses=1]
store i32 %tmp10, i32* %tmp, align 4
%tmp11 = load i32* %tmp, align 4 ; [#uses=1]
store i32 %tmp11, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval12 = load i32* %retval ; [#uses=1]
ret i32 %retval12
}

declare i32 @​bar(...)

define i32 @​foo2(i32 %i) nounwind {
entry:
%i_addr = alloca i32 ; <i32*> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%P = alloca i32* ; <i32**> [#uses=3]
%tmp = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 %i, i32* %i_addr
store i32* getelementptr ([100 x i32]* @​Arr, i32 0, i32 0), i32** %P, align 8
%tmp1 = load i32** %P, align 8 ; <i32*> [#uses=1]
%tmp2 = getelementptr i32* %tmp1, i64 1 ; <i32*> [#uses=1]
store i32* %tmp2, i32** %P, align 8
%tmp3 = load i32* %i_addr, align 4 ; [#uses=1]
%tmp34 = sext i32 %tmp3 to i64 ; [#uses=1]
%tmp5 = getelementptr i32* getelementptr ([100 x i32]* @​Arr, i32 0, i32 0), i64 %tmp34 ; <i32*> [#uses=1]
%tmp7 = call i32 (...)* @​bar( i32* %tmp5 ) nounwind ; [#uses=1]
store i32 %tmp7, i32* %tmp, align 4
%tmp9 = load i32* %tmp, align 4 ; [#uses=1]
store i32 %tmp9, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval10 = load i32* %retval ; [#uses=1]
ret i32 %retval10
}
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c: In function ‘test’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c:9: warning: cast from pointer to integer of different size
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c: At top level:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c:13: warning: cast from pointer to integer of different size
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c: In function ‘foo2’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-01-02-ConstantInits.c:20: warning: cast from pointer to integer of different size

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-03-06-OffsetOfStructCrash.c
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-03-06-OffsetOfStructCrash.c -S -o -
; ModuleID = '/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-03-06-OffsetOfStructCrash.c'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"

define void @​test1() nounwind {
entry:
br label %return

return: ; preds = %entry
ret void
}

define void @​test2() nounwind {
entry:
br label %return

return: ; preds = %entry
ret void
}
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-03-06-OffsetOfStructCrash.c: In function ‘test1’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2005-03-06-OffsetOfStructCrash.c:9: warning: cast from pointer to integer of different size

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-02-16-VoidPtrDiff.c
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-02-16-VoidPtrDiff.c -S -o - -emit-llvm
; ModuleID = '/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-02-16-VoidPtrDiff.c'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"

define void @​foo(i8* %ptr, i32 %test) nounwind {
entry:
%ptr_addr = alloca i8* ; <i8**> [#uses=2]
%test_addr = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i8* %ptr, i8** %ptr_addr
store i32 %test, i32* %test_addr
%tmp = load i8** %ptr_addr, align 8 ; <i8*> [#uses=1]
%tmp1 = ptrtoint i8* %tmp to i64 ; [#uses=0]
%tmp3 = load i32* %test_addr, align 4 ; [#uses=1]
%tmp34 = sext i32 %tmp3 to i64 ; [#uses=1]
%tmp3456 = inttoptr i64 %tmp34 to i8* ; <i8*> [#uses=1]
%tmp9 = getelementptr i8* %tmp3456, i64 8192 ; <i8*> [#uses=1]
%tmp91011 = ptrtoint i8* %tmp9 to i64 ; [#uses=0]
br label %return

return: ; preds = %entry
ret void
}
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-02-16-VoidPtrDiff.c: In function ‘foo’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-02-16-VoidPtrDiff.c:4: warning: cast to pointer from integer of different size

FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-09-14-NegatePointer.c for #2034
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm -S /home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-09-14-NegatePointer.c -o -
; ModuleID = '/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-09-14-NegatePointer.c'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"

define i32 @​foo(i8* %test) nounwind {
entry:
%test_addr = alloca i8* ; <i8**> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%tmp = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i8* %test, i8** %test_addr
%tmp1 = load i8** %test_addr, align 8 ; <i8*> [#uses=1]
%tmp12 = ptrtoint i8* %tmp1 to i64 ; [#uses=1]
%tmp1234 = trunc i64 %tmp12 to i32 ; [#uses=1]
%tmp6 = sub i32 0, %tmp1234 ; [#uses=1]
store i32 %tmp6, i32* %tmp, align 4
%tmp8 = load i32* %tmp, align 4 ; [#uses=1]
store i32 %tmp8, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval9 = load i32* %retval ; [#uses=1]
ret i32 %retval9
}
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-09-14-NegatePointer.c: In function ‘foo’:
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC/2007-09-14-NegatePointer.c:5: warning: cast from pointer to integer of different size

Running /home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/dg.exp ...
FAIL: /home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/2007-01-06-PtrMethodInit.cpp for #1456
Failed with unknown error (or has stderr output) at line 1
while running: /usr/local/bin/llvm-gcc -emit-llvm /home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/2007-01-06-PtrMethodInit.cpp -emit-llvm -S -o -
; ModuleID = '/home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/2007-01-06-PtrMethodInit.cpp'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"
%struct.EventDispatchData = type { i32, %struct.GenericHandler, i8 }
%struct.EventTypeData = type { %struct.EventDispatchData*, i32, %struct.nsIDOMEvent* }
%struct.GenericHandler = type { i32 (%struct.nsIDOMEventListener*, %struct.nsIDOMEvent*), i64 }
%struct.anon = type { i32 (%struct.nsIDOMMouseListener, %struct.nsIDOMEvent*), i64 }
%struct.nsIDOMEvent = type <{ i8 }>
%struct.nsIDOMEventListener = type { i32 (...)** }
%struct.nsIDOMMouseListener = type { %struct.nsIDOMEventListener }
%struct.nsIID = type <{ i8 }>
@​_ZL11sEventTypes = internal global [1 x %struct.EventTypeData] [ %struct.EventTypeData {
%struct.EventDispatchData bitcast ([1 x { i32, %struct.anon, i8 }]* @​_ZL12sMouseEvents to %struct.EventDispatchData*),
i32 1,
%struct.nsIDOMEvent* null } ], align 16 ; <[1 x %struct.EventTypeData]> [#uses=2]
@​_ZL12sMouseEvents = internal constant [1 x { i32, %struct.anon, i8 }] [ { i32, %struct.anon, i8 } {
i32 302,
%struct.anon { i32 (%struct.nsIDOMMouseListener, %struct.nsIDOMEvent*)* inttoptr (i64 9 to i32 (%struct.nsIDOMMouseListener*, %struct.nsIDOMEvent*)), i64 0 },
i8 1 } ], align 32 ; <[1 x { i32, %struct.anon, i8 }]> [#uses=2]
@​llvm.global_ctors = appending global [1 x { i32, void ()* }] [ { i32, void ()* } { i32 65535, void ()* @​_GLOBAL__I_2007_01_06_PtrMethodInit.cpp } ] ; <[1 x { i32, void ()* }]*> [#uses=0]

define linkonce %struct.nsIDOMEvent* @​_ZN13nsCOMTypeInfoI19nsIDOMMouseListenerE6GetIIDEv() nounwind {
entry:
%retval = alloca %struct.nsIDOMEvent* ; <%struct.nsIDOMEvent**> [#uses=1]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
br label %return

return: ; preds = %entry
%retval1 = load %struct.nsIDOMEvent** %retval ; <%struct.nsIDOMEvent*> [#uses=1]
ret %struct.nsIDOMEvent* %retval1
}

define internal void @​_GLOBAL__I_2007_01_06_PtrMethodInit.cpp() nounwind {
entry:
call void @​_Z41__static_initialization_and_destruction_0ii( i32 1, i32 65535 ) nounwind
br label %return

return: ; preds = %entry
ret void
}

define internal void @​_Z41__static_initialization_and_destruction_0ii(i32 %__initialize_p, i32 %__priority) nounwind {
entry:
%__initialize_p_addr = alloca i32 ; <i32*> [#uses=2]
%__priority_addr = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 %__initialize_p, i32* %__initialize_p_addr
store i32 %__priority, i32* %__priority_addr
%tmp = load i32* %__initialize_p_addr, align 4 ; [#uses=1]
%tmp1 = icmp eq i32 %tmp, 1 ; [#uses=1]
%tmp12 = zext i1 %tmp1 to i8 ; [#uses=1]
%toBool = icmp ne i8 %tmp12, 0 ; [#uses=1]
br i1 %toBool, label %bb, label %bb10

bb: ; preds = %entry
%tmp3 = load i32* %__priority_addr, align 4 ; [#uses=1]
%tmp4 = icmp eq i32 %tmp3, 65535 ; [#uses=1]
%tmp45 = zext i1 %tmp4 to i8 ; [#uses=1]
%toBool6 = icmp ne i8 %tmp45, 0 ; [#uses=1]
br i1 %toBool6, label %bb7, label %bb10

bb7: ; preds = %bb
%tmp8 = call %struct.nsIDOMEvent* @​_ZN13nsCOMTypeInfoI19nsIDOMMouseListenerE6GetIIDEv( ) nounwind ; <%struct.nsIDOMEvent*> [#uses=1]
store %struct.nsIDOMEvent* %tmp8, %struct.nsIDOMEvent** getelementptr ([1 x %struct.EventTypeData]* @​_ZL11sEventTypes, i32 0, i64 0, i32 2), align 8
br label %bb10

bb10: ; preds = %bb7, %bb, %entry
br label %return

return: ; preds = %bb10
ret void
}
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/2007-01-06-PtrMethodInit.cpp:37: warning: ‘cdecl’ attribute ignored
/home/duncan/LLVM/llvm.top/llvm/test/FrontendC++/2007-01-06-PtrMethodInit.cpp:48: warning: ‘cdecl’ attribute ignored

[matthijskooijman]

Fixing those would probably be best, though suppressing them a lot easier. Isn't there some gcc flag to silence those warnings?

[lattner]

we need to fix the dejagnu harness to not die with warnings, this is silly.

[matthijskooijman]

I would rather do this on a test-by-test basis, by just adding 2>/dev/null.

However, if you really want to fix this on the dejagnu level, someone should figure out this eval-try-exec-catch magic in TCL, which i didn't. Alternatively, we could fix it for TCL version one-newer-than-what's-in-ubuntu-7 (8.5 IIRC), since that has a neat switch for the exec command...