openmp offloading/offloading_success.c and .cpp tests fail on the 5.0 branch

[zmodem]

Bugzilla Link	33859
Resolution	FIXED
Resolved on	Jul 26, 2017 08:47
Version	unspecified
OS	Linux
Blocks	#33196
CC	@grokos,@hahnjo,@hfinkel

Extended Description

When running the test-release.sh script for the 5.0 branch on Linux, the openmp tests fail as below.

Are these tests run on any buildbots somewhere?

FAIL: libomptarget :: offloading/offloading_success.c (42977 of 44229)
******************** TEST 'libomptarget :: offloading/offloading_success.c' FAILED ********************
Script:

echo ignored-command
echo ignored-command
echo ignored-command
/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/clang -fopenmp=libomp -I /work/release-test/branches_release_50/llvm
.src/projects/openmp/libomptarget/test -I /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/../
runtime/src -L /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/lib -lomptarget -fopenmp-targets=x86_64-pc-linux-gnu /usr/
local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.c -o /usr/local/google/work/release-test/b
ranches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/offloading_success.c.tmp-x86_64-pc-linux-g
nu && /usr/local/google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output
/offloading_success.c.tmp-x86_64-pc-linux-gnu | /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/FileCheck /usr/local
/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.c

Exit Code: 1

Command Output (stdout):

$ "echo" "ignored-command"

command output:

ignored-command

$ "echo" "ignored-command"

command output:

ignored-command

$ "echo" "ignored-command"

command output:

ignored-command

$ "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/clang" "-fopenmp=libomp" "-I" "/work/release-test/branches_releas
e_50/llvm.src/projects/openmp/libomptarget/test" "-I" "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/lib
omptarget/../runtime/src" "-L" "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/lib" "-lomptarget" "-fopenmp-targets=x86_6
4-pc-linux-gnu" "/usr/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.c" "-o" "/usr/local/
google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/offloading_succe
ss.c.tmp-x86_64-pc-linux-gnu"
$ "/usr/local/google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/of
floading_success.c.tmp-x86_64-pc-linux-gnu"
note: command had no output on stdout or stderr
error: command failed with exit status: 1
$ "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/FileCheck" "/usr/local/google/work/release-test/branches_release_
50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.c"

command stderr:

/usr/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.c:19:12: error: expected string not f
ound in input
// CHECK: Target region executed on the device
^
:1:1: note: scanning from here
Target region executed on the host
^

error: command failed with exit status: 1

---

Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
FAIL: libomptarget :: offloading/offloading_success.cpp (42981 of 44229)
******************** TEST 'libomptarget :: offloading/offloading_success.cpp' FAILED ********************
Script:

echo ignored-command
echo ignored-command
echo ignored-command
/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/clang++ -fopenmp=libomp -I /work/release-test/branches_release_50/ll
vm.src/projects/openmp/libomptarget/test -I /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/.
./runtime/src -L /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/lib -lomptarget -fopenmp-targets=x86_64-pc-linux-gnu /us
r/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.cpp -o /usr/local/google/work/release-te
st/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/offloading_success.cpp.tmp-x86_64-pc-l
inux-gnu && /usr/local/google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/
Output/offloading_success.cpp.tmp-x86_64-pc-linux-gnu | /work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/FileCheck /u
sr/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.cpp

Exit Code: 1

Command Output (stdout):

$ "echo" "ignored-command"

command output:

ignored-command

$ "echo" "ignored-command"

command output:

ignored-command

$ "echo" "ignored-command"

command output:

ignored-command

$ "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/clang++" "-fopenmp=libomp" "-I" "/work/release-test/branches_rele
ase_50/llvm.src/projects/openmp/libomptarget/test" "-I" "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/l
ibomptarget/../runtime/src" "-L" "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/lib" "-lomptarget" "-fopenmp-targets=x86
64-pc-linux-gnu" "/usr/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.cpp" "-o" "/usr/lo
cal/google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/offloading_s
uccess.cpp.tmp-x86_64-pc-linux-gnu"
$ "/usr/local/google/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/projects/openmp/libomptarget/test/offloading/Output/of
floading_success.cpp.tmp-x86_64-pc-linux-gnu"
note: command had no output on stdout or stderr
error: command failed with exit status: 1
$ "/work/release-test/branches_release_50/Phase3/Release/llvmCore-test-branches_release_50.obj/./bin/FileCheck" "/usr/local/google/work/release-test/branches_release
50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.cpp"

command stderr:

/usr/local/google/work/release-test/branches_release_50/llvm.src/projects/openmp/libomptarget/test/offloading/offloading_success.cpp:19:12: error: expected string not
found in input
// CHECK: Target region executed on the device
^
:1:1: note: scanning from here
Target region executed on the host
^

error: command failed with exit status: 1

[zmodem]

assigned to @hahnjo

[hahnjo]

I think these tests are not run by a buildbot currently as some Clang part is still missing. As such, it would be best to remove these tests for 5.0.

Alternatively, we could remove the libomptarget completely as the NVIDIA part does not work yet. But you should wait for the IBM guys before doing so.

[zmodem]

I think these tests are not run by a buildbot currently as some Clang part
is still missing. As such, it would be best to remove these tests for 5.0.

Alternatively, we could remove the libomptarget completely as the NVIDIA
part does not work yet. But you should wait for the IBM guys before doing so.

It sounds like libomptarget should be put behind a build flag so that it isn't built by default, then.

Can you prepare such a patch, and then I'll merge it to the 5.0 branch?

[hahnjo]

It sounds like libomptarget should be put behind a build flag so that it
isn't built by default, then.

Can you prepare such a patch, and then I'll merge it to the 5.0 branch?
Agreed for 5.0, but I'd like to keep it enabled in trunk by default. I've prepared https://reviews.llvm.org/D35719 to introduce a new CMake switch. The default can be adjusted when ported to release_50.

[hahnjo]

Hans, I've committed the patch. Will you take care to merge the change into release_50?

[zmodem]

Hans, I've committed the patch. Will you take care to merge the change into
release_50?

Yes, I've merged it in r309126. Thanks!