After r308791 there are numerous test case failures in bootstrap build

[llvmbot]

Bugzilla Link	33928
Resolution	FIXED
Resolved on	Aug 03, 2017 09:32
Version	trunk
OS	Linux
Blocks	#33196
Reporter	LLVM Bugzilla Contributor
CC	@echristo,@erichkeane,@zmodem,@nemanjai

Extended Description

You can see the failures here in the buildbot results:

http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/3289

Failures were occurring earlier but were masked by a compilation problem introduced by an even earlier revision.

---

Failing Tests (9):
Clang :: CodeGen/avx512-reduceIntrin.c
Clang :: CodeGen/avx512-reduceMinMaxIntrin.c
Clang :: CodeGen/avx512f-builtins.c
Clang :: CodeGen/vector-alignment.c
Clang :: CodeGen/x86-inline-asm-v-constraint.c
Clang :: CodeGen/x86_64-arguments.c
Clang :: OpenMP/simd_metadata.c
Clang :: Preprocessor/predefined-arch-macros.c
Clang :: Preprocessor/x86_target_features.c

Expected Passes : 33554
Expected Failures : 178
Unsupported Tests : 938
Unexpected Failures: 9

Some of the details:

FAIL: Clang :: CodeGen/avx512-reduceMinMaxIntrin.c (5240 of 34679)
******************** TEST 'Clang :: CodeGen/avx512-reduceMinMaxIntrin.c' FAILED ********************
Script:

/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -ffreestanding /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceMinMaxIntrin.c -O2 -triple=x86_64-apple-darwin -target-cpu skylake-avx512 -emit-llvm -o - -Wall -Werror |/home/seurer/llvm/build/llvm-test/./bin/opt -instnamer -S |/home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceMinMaxIntrin.c

Exit Code: 1

Command Output (stderr):

/home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceMinMaxIntrin.c:9:12: error: expected string not found in input
// CHECK: %tmp = icmp slt <8 x i64> %shuffle1.i, %__W
^
:11:2: note: scanning from here
%tmp = icmp sgt <8 x i64> %__W, %shuffle1.i
^

--

******************** TEST 'Clang :: CodeGen/vector-alignment.c' FAILED ********************
Script:

/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple x86_64-apple-darwin10 -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=SSE
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple i386-apple-darwin10 -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=SSE
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple x86_64-apple-darwin10 -target-feature +avx -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=AVX
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple i386-apple-darwin10 -target-feature +avx -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=AVX
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple x86_64-apple-darwin10 -target-feature +avx512f -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=AVX512
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -w -triple i386-apple-darwin10 -target-feature +avx512f -emit-llvm -o - /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c --check-prefix=ALL --check-prefix=AVX512

Exit Code: 1

Command Output (stderr):

/home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/vector-alignment.c:31:12: error: expected string not found in input
// AVX512: @​v3 {{.*}}, align 64
^
:8:1: note: scanning from here
@​v3 = common global <8 x double> zeroinitializer, align 32
^
:11:41: note: possible intended match here
@​v6 = common global <2 x double> zeroinitializer, align 64
^

--

FAIL: Clang :: CodeGen/avx512-reduceIntrin.c (5410 of 34679)
******************** TEST 'Clang :: CodeGen/avx512-reduceIntrin.c' FAILED ********************
Script:

/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem /home/seurer/llvm/build/llvm-test/lib/clang/6.0.0/include -nostdsysteminc -ffreestanding /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceIntrin.c -O2 -triple=x86_64-apple-darwin -target-cpu skylake-avx512 -emit-llvm -o - -Wall -Werror | /home/seurer/llvm/build/llvm-test/./bin/FileCheck /home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceIntrin.c

Exit Code: 1

Command Output (stderr):

/home/seurer/llvm/llvm-test/tools/clang/test/CodeGen/avx512-reduceIntrin.c:125:12: error: expected string not found in input
// CHECK: {{.}} = bitcast <8 x i64> %__W to <16 x i32>
^
:140:1: note: scanning from here
}
^
:145:2: note: possible intended match here
%1 = bitcast <8 x i64> %0 to <16 x i32>*
^

--

[erichkeane]

I'm unsure how my patch would have caused this, but I'm taking a look. It didn't reproduce with check-all when I submitted the patch initially, but I'm trying again with the latest trunk.

Anything special I have to do to repro?

[llvmbot]

I built revision 308791 then used that freshly built clang to rebuild and then run the tests. That's all.

I verified it was this revision by doing the same with 308790 and all was well.

[erichkeane]

So were you able to get this to happen on a NON PPC architecture? (Say x86-64 :))? Is it simply self-build?

[zmodem]

It would be nice if this could be figured out for 5.0.

[echristo]

Adding Kit and Nemanja for help here. If this doesn't get fixed in the near term we should probably revert and figure it out.

[erichkeane]

Doing my best Hans :)
If I could get access to a PPC64LE machine to debug, I'd likely be able to get through it faster, though Bill has been extremely helpful in running things for me.

[nemanjai]

Adding Hiroshi who is working on a fix for this. He has it narrowed down to an issue in stack coloring not respecting TBAA info that this patch just happened to expose.
I'll let him explain it and offer a solution.

[llvmbot]

I submitted a (WIP) patch in Phabricator. https://reviews.llvm.org/D35907

As Nemanja mentioned above, this problem is caused by incorrect TBAA metadata when the stack coloring pass merges two stack slots of different types.
This problem is not specific to PPC and potentially other platforms can suffer from similar problems.
I believe that r308791 does not do anything bad; it just reveals a hidden bug in CodeGen.

[llvmbot]

Patch committed. https://reviews.llvm.org/rL309651

[llvmbot]

After another issue is fixed, the build status is now clean on the buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/3396

[zmodem]

After another issue is fixed, the build status is now clean on the buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/3396

What was the other issue?

[llvmbot]

Some compiler-rt tests were once enabled on ppc64, but it caused a couple of failures.
https://reviews.llvm.org/rL309634

[llvmbot]

Additional patch committed in https://reviews.llvm.org/rL309849

[zmodem]

Merged both patches to 5.0 in r309957.