Merge r312292, r312296 into the 5.0 branch: Fix for #34398 : assert with random access iterator if the step>1.

[hahnjo]

Bugzilla Link	35179
Resolution	FIXED
Resolved on	Nov 13, 2017 15:42
Version	unspecified
OS	All
Blocks	#33840
CC	@alexey-bataev,@hfinkel,@tstellar
Fixed by commit(s)	r312292 r312296 r318113 r318114

Extended Description

If the loop is a loot with random access iterators and the iteration
construct is represented it += n, then the compiler crashed because of
reusing of the same MaterializedTemporaryExpr around N. Patch fixes it
by using the expression as written, without any special kind of
wrappings.

Note: I'm not really sure if we should merge this one: It touches quite a few tests and needs the second commit to fix the test. Just marking this for discussion, feel free to close if we don't want to merge it.

[hahnjo]

assigned to @alexey-bataev

[tstellar]

Hi Alexey,

Are these OK to merge to the release_50 branch:
https://reviews.llvm.org/rL312292
https://reviews.llvm.org/rL312296

[alexey-bataev]

Yes

[tstellar]

Merged: r318113 r318114