Clang-Format script for vim fails if a line range is given #34716
Description
| Bugzilla Link | 35368 |
| Resolution | FIXED |
| Resolved on | Nov 28, 2017 08:20 |
| Version | 5.0 |
| OS | Linux |
| Blocks | #33840 |
| Reporter | LLVM Bugzilla Contributor |
| CC | @zmodem,@krasimir-google,@tstellar |
| Fixed by commit(s) | r311456 r319179 |
Extended Description
Basically the following is executed from "/clang-format.py" if you define l:lines=59:72 before calling:
['clang-format', '-style', 'file', '-cursor', '1658', '6', '9', ':', '7', '2', '-assume-filename', '/tmp/foo.cpp']
but the correct command would be
['clang-format', '-style', 'file', '-cursor', '1658', '-lines', '68:72', '-assume-filename', '/tmp/foo.cpp']
Line 96 with "command += lines" is the culprit and has to be "command.extend(["-lines", lines])"
It would be nice if someone can make a commit from this - I have had a look at the "Getting involved" pages but have no experience with svn / svn patch generation and am not willing to invest a lot of time for this one liner. For the next time - would it be better to send a message like this to one of the mailing lists or did I do the 'right' thing in opening a bug?
Thank you for your hard work! :)