Please backport r316106 to 5.0.1 [lldb-server tests: Fix undefined behavior]

[llvmbot]

Bugzilla Link	35380
Resolution	FIXED
Resolved on	Nov 27, 2017 07:22
Version	5.0
OS	Linux
Blocks	#33840
Reporter	LLVM Bugzilla Contributor
CC	@tstellar
Fixed by commit(s)	r316106 r319035

Extended Description

Please backport the following commit to 5.0.1 release branch:

commit 0586d1e0d192c67f3df93cfef625235c7e8986da
Author: Pavel Labath labath@google.com
Date: Wed Oct 18 20:52:16 2017

lldb-server tests: Fix undefined behavior

We were creating a StringRef pointing to a temporary string. Problem manifested
itself when running the test on osx.

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@316106 91177308-0d34-0410-b5e6-96231b3b80d8

Contrary to the commit message, we're reliably hitting this on Gentoo Linux. I think that's the last test failure in release_50.

[tstellar]

Hi Zachary,

Is this OK to merge to the release_50 branch?
https://reviews.llvm.org/rL316106

[llvmbot]

Looks fine to me.

[tstellar]

Merged: r319035