Skip to content

DenseMapCustomTest.DefaultMinReservedSizeTest FAILs on Solaris/SPARC #53523

@rorth

Description

@rorth

After D91608, the DenseMapCustomTest.DefaultMinReservedSizeTest test FAILs on Solaris/SPARC (both 32 and 64-bit):

  SanitizerCommon-Unit :: ./Sanitizer-sparc-Test/DenseMapCustomTest.DefaultMinReservedSizeTest
  SanitizerCommon-Unit :: ./Sanitizer-sparcv9-Test/DenseMapCustomTest.DefaultMinReservedSizeTest

like this:

[ RUN      ] DenseMapCustomTest.DefaultMinReservedSizeTest
/vol/llvm/src/llvm-project/local/compiler-rt/lib/sanitizer_common/tests/sanitizer_dense_map_test.cpp:399: Failure
Expected: (MemorySize) != (Map.getMemorySize()), actual: 8192 vs 8192

Solaris/SPARC uses a default page size of 8192, so ISTM that the

  KV.first = ExpectedMaxInitialEntries;
  Map.insert(move(KV));

doesn't need to grow the allocation, unlike the case on systems (like Solaris/x86) with 4 kB pages.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions