Simplify initialisation diagnostic when types are cv-qualified

[cjdb]

I'd like to revise the diagnostic

error: cannot initialize a variable of type 'const icun_status' with an rvalue of type 'int'

to

error: cannot initialize a constant of type 'icun_status' with an rvalue of type 'int'

The const in this diagnostic doesn't appear to be doing much other than ensuring (unnecessary) technical accuracy. I don't think similar nouns exist for volatile and restrict don't exist: they can remain variable.

I have self-assigned, but this is a good candidate for someone looking to get started with Clang, and I'll happily hand it off in that case.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Assign the issue to you.
2. Fix the issue locally.
3. Run the test suite locally.
   3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
   e.g. use make check-clang-ast to only run Clang's AST tests.
4. Create a git commit
5. Run git clang-format HEAD~1 to format your changes.
6. Submit the patch to Phabricator.
   6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Christopher Di Bella (cjdb)

I'd like to revise the diagnostic ``` error: cannot initialize a variable of type 'const icun_status' with an rvalue of type 'int' ``` to ``` error: cannot initialize a constant of type 'icun_status' with an rvalue of type 'int' ```

The const in this diagnostic doesn't appear to be doing much other than ensuring (unnecessary) technical accuracy. I don't think similar nouns exist for volatile and restrict don't exist: they can remain variable.

I have self-assigned, but this is a good candidate for someone looking to get started with Clang, and I'll happily hand it off in that case.

[cjdb]

Don't submit the patch to Phabricator: instead make a Pull Request on this project.

[NoumanAmir657]

I would like to work on this

[NoumanAmir657]

@cjdb
Grepping the "const icun_status" leads to no matches in the repo. Can you elaborate on this or am I missing something here.