More VMCore Cleanups (.cpp files)

[llvmbot]

Bugzilla Link	403
Resolution	FIXED
Resolved on	Mar 06, 2010 14:06
Version	1.0
OS	All
Reporter	LLVM Bugzilla Contributor

Extended Description

The placement of methods into .cpp files in lib/VMCore is somewhat awkward. Of
particular note:

1. GlobalVariable::* is at the end of Function.cpp
2. GlobalValue::* is at the end of Constant.cpp
3. the various i*.cpp files should just be put in Instructions.cpp
4. Correspondingly, the include/llvm/i*.h files should go in Instructions.h

There's probably several other cleanups but two things need to be balanced here:

1. The need to put significant amounts of code in .cpp files so that we aren't
   spending our compile time processing header files
2. The need to put member functions in .cpp files that make sense, are easy to
   find and are intuitive.

[lattner]

Alkis took care of #​3 here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040726/016587.html

... and #​4 here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040726/016583.html

Thanks Alkis!

-Chris

[llvmbot]

Since I took care of #​1 and #​2 with my CPR changes, is this bug done? The four
items listed are done, but was there more cleanup intended by this bug? If not,
we should resolve it.

[lattner]

Thanks to the efforts of Reid, Alkis, and Misha, this PR is now fixed.

-Chris