clang/lib/Sema/SemaExpr.cpp:17213: Pointless test ?

[dcb314]

Static analyser cppcheck says:

clang/lib/Sema/SemaExpr.cpp:17213:16: style: Expression is always true because 'else if' condition is opposite to previous condition at line 17211. [multiCondition]

Source code is

if (!CheckInferredResultType) {
  ConvHints.tryToFixConversion(SrcExpr, SrcType, DstType, *this);
} else if (CheckInferredResultType) {

Second if looks pointless to me. Suggest code rework.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (dcb314)

Static analyser cppcheck says:

clang/lib/Sema/SemaExpr.cpp:17213:16: style: Expression is always true because 'else if' condition is opposite to previous condition at line 17211. [multiCondition]

Source code is

if (!CheckInferredResultType) {
  ConvHints.tryToFixConversion(SrcExpr, SrcType, DstType, *this);
} else if (CheckInferredResultType) {

Second if looks pointless to me. Suggest code rework.