Problem with lib/Support/Windows/DynamicLibrary.inc and mingw-w64

[rubenvb]

Bugzilla Link	8848
Resolution	FIXED
Resolved on	Mar 16, 2011 16:49
Version	trunk
OS	Windows NT
Blocks	llvm/llvm-bugzilla-archive#9072
Attachments	patch to remedy the problem
CC	@rubenvb

Extended Description

On both x86 and x64 toolchains from mingw-w64.sourceforge.net, the build fails due to the assumption made that a certain winAPI function is unavailable and a different declaration is provided. This was probably necessary for mingw.org, but is bad for mingw-w64 (who are more compatible with MSVC in this regard).

A trivial patch with a check for mingw-w64 toolchain is attached. It also fixes a _WIN32_WINNT macro redefinition warning.

[llvmbot]

Hi, today, I use a gcc 4.5.2 version with mingw64 api to build the llvm and clang, but failed with log below:

---

llvm[1]: Compiling DynamicLibrary.cpp for Release build
In file included from e:/svn_llvm/llvm/lib/Support/Windows/DynamicLibrary.inc:14
:0,
from e:/svn_llvm/llvm/lib/Support/DynamicLibrary.cpp:50:
e:/svn_llvm/llvm/lib/Support/Windows/Windows.h:20:0: warning: "_WIN32_WINNT" red
efined
d:\code\mingwpcx\bin../lib/gcc/i686-pc-mingw32/4.5.2/../../../../i686-pc-mingw3
2/include/_mingw.h:235:0: note: this is the location of the previous definition
In file included from e:/svn_llvm/llvm/lib/Support/DynamicLibrary.cpp:50:0:
e:/svn_llvm/llvm/lib/Support/Windows/DynamicLibrary.inc: In static member functi
on 'static bool llvm::sys::DynamicLibrary::LoadLibraryPermanently(const char*, s
td::string*)':
e:/svn_llvm/llvm/lib/Support/Windows/DynamicLibrary.inc:103:64: error: invalid c
onversion from 'BOOL ()(CHAR, llvm::ModuleBaseType, ULONG, void*)' to 'WINBOOL
()(const CHAR, ULONG, ULONG, void*)'
e:/svn_llvm/llvm/lib/Support/Windows/DynamicLibrary.inc:103:64: error: initial
izing argument 2 of 'WINBOOL EnumerateLoadedModules(void*, WINBOOL ()(const CHA
R, ULONG, ULONG, void*), void*)'
/bin/rm: cannot lstat /e/svn_llvm/build/lib/Support/Release/DynamicLibrary.d.tm p': No such file or directory make[1]: *** [/e/svn_llvm/build/lib/Support/Release/DynamicLibrary.o] Error 1 make[1]: Leaving directory /e/svn_llvm/build/lib/Support'
make: *** [install] Error 1

---

I have returned to a gcc 4.4.5 with Mingw API, and it works fine.
Hope your patch can solve my problem.

thanks.

asmwarrior
ollydbg from codeblocks' forum.

[llvmbot]

I believe I fixed it in r125169, r125170 and around.

[llvmbot]

Here is the code snip:

#if defined(_MSC_VER)
#if _MSC_VER < 1500 && (!defined(VER_PRODUCTBUILD) || VER_PRODUCTBUILD < 6000)
#define OLD_ELM_CALLBACK_DECL 1
#endif
#elif defined(MINGW64)
// Use new callback.
#elif defined(MINGW32)
#define OLD_ELM_CALLBACK_DECL 1
#endif

The above code depend on MINGW64 defined on mingw64-gcc.
But this is not true, mingw64-gcc did not define MINGW64.

1. If you want distinguish mingw32 and mingw-w64, please refer the following mail
   thread:

Is there are ways to distinguish mingw32 and mingw-w64 (32bit) compiler?
http://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg02056.html

2. Or you can just check if API_VERSION_NUMBER>=11, as sezero preferred:

http://www.ma

[llvmbot]

I know we might not support i686-w64-mingw32 for now, (at least in 2.9)
You may reopen this. Regardless of you, I will not forget w64-mingw32 issues. ;)

For this issue, I think it would be better for configurator(autoconf and cmake) to detect and check the decl.

[llvmbot]

Here is the code snip:

#if defined(_MSC_VER)
#if _MSC_VER < 1500 && (!defined(VER_PRODUCTBUILD) || VER_PRODUCTBUILD < 6000)
#define OLD_ELM_CALLBACK_DECL 1
#endif
#elif defined(MINGW64)
// Use new callback.
#elif defined(MINGW32)
#define OLD_ELM_CALLBACK_DECL 1
#endif

The above code depend on MINGW64 defined on mingw64-gcc.
But this is not true, mingw64-gcc did not define MINGW64.

1. If you want distinguish mingw32 and mingw-w64, please refer the following mail
   thread:

Is there are ways to distinguish mingw32 and mingw-w64 (32bit) compiler?
http://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg02056.html

2. Or you can just check if API_VERSION_NUMBER>=11, as sezero preferred:

http://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg02046.html

#if !defined(API_VERSION_NUMBER) || API_VERSION_NUMBER < 11
#define OLD_ELM_CALLBACK_DECL 1
#endif

3. Or you can use EnumerateLoadedModules64 instead of EnumerateLoadedModules, as
   Microsoft preferred:

http://msdn.microsoft.com/en-us/library/ms679316%28VS.85%29.aspx
This function supersedes the EnumerateLoadedModules function.
For more information, see Updated Platform Support.

[rubenvb]

mentioned in issue llvm/llvm-bugzilla-archive#9072