We now classify this use of friend as invalid

[llvmbot]

Bugzilla Link	9229
Resolution	FIXED
Resolved on	Feb 15, 2011 16:52
Version	trunk
OS	All
Reporter	LLVM Bugzilla Contributor
CC	@DougGregor,@tkremenek,@rjmccall

Extended Description

After 125485 we reject

class LIns {
void staticSanityCheck();
};
class LInsOp2 {
private:
friend class LIns;
LIns ins;
};
void LIns::staticSanityCheck() {
void nano_static_assert(int arg[__builtin_offsetof(LInsOp2, ins)]);
}

[tkremenek]

cloned to rdar://problem/9006053

[tkremenek]

I cannot reproduce this in TOT (r125594).

[tkremenek]

Rafael: Does this still reproduce for you?

[llvmbot]

Sorry, the full test is

void nano_static_assert(int arg[1]);
class LIns {
void staticSanityCheck();
};
class LInsOp2 {
private:
friend class LIns;
LIns ins;
};
void LIns::staticSanityCheck() {
void nano_static_assert(int arg[__builtin_offsetof(LInsOp2, ins)]);
}

It was missing the first line.

[tkremenek]

Sorry, the full test is

void nano_static_assert(int arg[1]);
class LIns {
void staticSanityCheck();
};
class LInsOp2 {
private:
friend class LIns;
LIns ins;
};
void LIns::staticSanityCheck() {
void nano_static_assert(int arg[__builtin_offsetof(LInsOp2, ins)]);
}

It was missing the first line.

Thanks, I can now reproduce.

[rjmccall]

r125609.