goto out of try block to no-return function generates invalid IR

[llvmbot]

Bugzilla Link	9302
Resolution	FIXED
Resolved on	Aug 25, 2011 18:25
Version	trunk
OS	FreeBSD
Attachments	test case
Reporter	LLVM Bugzilla Contributor
CC	@rjmccall

Extended Description

pes delta$ clang++ httpd.cxx

.... warnings ....

Assertion failed: (T && "getTerminator returned null!"), function SuccIterator, file /data/home/rdivacky/llvm/include/llvm/Support/CFG.h, line 105.
Stack dump:
0. Program arguments: /usr/local/bin/clang -cc1 -triple x86_64-unknown-freebsd8.1 -emit-obj -mrelax-all -disable-free -main-file-name httpd.cxx -mrelocation-model static -mdisable-fp-elim -masm-verbose -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-linker-version 2.15 -momit-leaf-frame-pointer -resource-dir /usr/local/bin/../lib/clang/2.9 -ferror-limit 19 -fmessage-length 152 -fexceptions -fgnu-runtime -fdiagnostics-show-option -fcolor-diagnostics -o /tmp/cc-iVeuoi.o -x c++ httpd.cxx

1.  <eof> parser at end of file
   

2.  Per-function optimization
   

3.  Running pass 'Dominator Tree Construction' on function '@_ZSt15response_threadPv'
   

clang: error: unable to execute command: Abort trap: 6 (core dumped)
clang: error: clang frontend command failed due to signal 1 (use -v to see invocation)
pes delta$

[lattner]

Here's a reduced testcase:

void pthread_exit(void *) attribute((noreturn));

struct foo {
foo();
~foo();
};

void test() {
foo a;
try {
foo b;
goto request_done;
}
catch(...) {
}

request_done:
pthread_exit(__null);
}

[lattner]

Specifically, the cleanup block is never added to the function.

[rjmccall]

This seems to pass on ToT now, and it looks a lot like something I fixed in r137011.