Skip to content

Add #ifndef NDEBUG/#endif around debug-only code. #147356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Add #ifndef NDEBUG/#endif around debug-only code. #147356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,8 +718,10 @@ SDValue DAGTypeLegalizer::SoftenFloatRes_ExpOp(SDNode *N) {
: RTLIB::getLDEXP(N->getValueType(0));
assert(LC != RTLIB::UNKNOWN_LIBCALL && "Unexpected fpowi.");
if (!TLI.getLibcallName(LC)) {
#ifndef NDEBUG
RTLIB::Libcall NewLC = RTLIB::getPOW(N->getValueType(0));
assert(NewLC != RTLIB::UNKNOWN_LIBCALL && "Unexpected fpow type");
Copy link
Collaborator

@RKSimon RKSimon Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not embed the getPOW call inside the assert?

Copy link
Contributor

@arsenm arsenm Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just delete the whole assert

Copy link
Contributor

@arsenm arsenm Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in a79acbd

#endif

// Some targets don't have a powi libcall; use pow instead.
// FIXME: Implement this if some target needs it.
Expand Down
Loading