-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[Offload] Update tablegen tests #156041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Offload] Update tablegen tests #156041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were not updated after llvm#154736 .
|
@llvm/pr-subscribers-offload Author: Ross Brunton (RossBrunton) ChangesThese were not updated after #154736 . Full diff: https://github.com/llvm/llvm-project/pull/156041.diff 8 Files Affected:
diff --git a/offload/test/tools/offload-tblgen/default_returns.td b/offload/test/tools/offload-tblgen/default_returns.td
index e919492cc5bf3..41949db7226ac 100644
--- a/offload/test/tools/offload-tblgen/default_returns.td
+++ b/offload/test/tools/offload-tblgen/default_returns.td
@@ -6,13 +6,11 @@
include "APIDefs.td"
-def : Handle {
- let name = "ol_foo_handle_t";
+def ol_foo_handle_t : Handle {
let desc = "Example handle type";
}
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/entry_points.td b/offload/test/tools/offload-tblgen/entry_points.td
index c66d5b488b464..94ea820d453ee 100644
--- a/offload/test/tools/offload-tblgen/entry_points.td
+++ b/offload/test/tools/offload-tblgen/entry_points.td
@@ -4,8 +4,7 @@
include "APIDefs.td"
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/functions_basic.td b/offload/test/tools/offload-tblgen/functions_basic.td
index dec93577b57e9..2802c78a2947e 100644
--- a/offload/test/tools/offload-tblgen/functions_basic.td
+++ b/offload/test/tools/offload-tblgen/functions_basic.td
@@ -6,8 +6,7 @@
include "APIDefs.td"
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/functions_code_loc.td b/offload/test/tools/offload-tblgen/functions_code_loc.td
index aec20129343f5..8d7aa00c5f15b 100644
--- a/offload/test/tools/offload-tblgen/functions_code_loc.td
+++ b/offload/test/tools/offload-tblgen/functions_code_loc.td
@@ -7,8 +7,7 @@
include "APIDefs.td"
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/functions_ranged_param.td b/offload/test/tools/offload-tblgen/functions_ranged_param.td
index d0996b231973b..1ce8b394b1575 100644
--- a/offload/test/tools/offload-tblgen/functions_ranged_param.td
+++ b/offload/test/tools/offload-tblgen/functions_ranged_param.td
@@ -8,13 +8,11 @@
include "APIDefs.td"
-def : Handle {
- let name = "some_handle_t";
+def some_handle_t : Handle {
let desc = "An example handle type";
}
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/print_enum.td b/offload/test/tools/offload-tblgen/print_enum.td
index 97f869689293d..c7573a9a415cb 100644
--- a/offload/test/tools/offload-tblgen/print_enum.td
+++ b/offload/test/tools/offload-tblgen/print_enum.td
@@ -4,8 +4,7 @@
include "APIDefs.td"
-def : Enum {
- let name = "my_enum_t";
+def my_enum_t : Enum {
let desc = "An example enum";
let etors =[
Etor<"VALUE_ONE", "The first enum value">,
diff --git a/offload/test/tools/offload-tblgen/print_function.td b/offload/test/tools/offload-tblgen/print_function.td
index ce1fe4c527608..74b39f145a400 100644
--- a/offload/test/tools/offload-tblgen/print_function.td
+++ b/offload/test/tools/offload-tblgen/print_function.td
@@ -5,13 +5,11 @@
include "APIDefs.td"
-def : Handle {
- let name = "ol_foo_handle_t";
+def ol_foo_handle_t : Handle {
let desc = "Example handle type";
}
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
diff --git a/offload/test/tools/offload-tblgen/type_tagged_enum.td b/offload/test/tools/offload-tblgen/type_tagged_enum.td
index 95964e32f0c9b..b32531aac9c81 100644
--- a/offload/test/tools/offload-tblgen/type_tagged_enum.td
+++ b/offload/test/tools/offload-tblgen/type_tagged_enum.td
@@ -9,13 +9,11 @@
include "APIDefs.td"
-def : Handle {
- let name = "some_handle_t";
+def some_handle_t: Handle {
let desc = "An example handle type";
}
-def : Enum {
- let name = "my_type_tagged_enum_t";
+def my_type_tagged_enum_t : Enum {
let desc = "Example type tagged enum";
let is_typed = 1;
let etors = [
@@ -34,8 +32,7 @@ def : Enum {
// CHECK-API-NEXT: [some_handle_t] Value three.
// CHECK-API-NEXT: MY_TYPE_TAGGED_ENUM_VALUE_THREE = 2,
-def : Function {
- let name = "FunctionA";
+def FunctionA : Function {
let desc = "Function A description";
let details = [ "Function A detailed information" ];
let params = [
|
mgorny
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the tests pass with this change. Thanks for the quick action!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not updated after #154736 .