[CI] Only invoke ninja for runtimes build if runtimes are specified #156969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we end up running ninja without any targets specified which just builds the rest of the default enabled targets. This shouldn't have too much impact, but can involve building extra things that we don't need. This also makes the monolithic-windows.sh script consistent with the monolithic-windows.sh script.
boomanaiden154
requested review from
Keenuts,
cmtice,
dschuff and
gburgessiv
cmtice
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we end up running ninja without any targets specified which just builds the rest of the default enabled targets. This shouldn't have too much impact, but can involve building extra things that we don't need.
This also makes the monolithic-windows.sh script consistent with the monolithic-windows.sh script.