Skip to content

Conversation

lei137
Copy link
Contributor

@lei137 lei137 commented Sep 5, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 5, 2025

@llvm/pr-subscribers-backend-powerpc

Author: Lei Huang (lei137)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/157135.diff

1 Files Affected:

  • (modified) llvm/lib/Target/PowerPC/PPCInstrFuture.td (+36-35)
diff --git a/llvm/lib/Target/PowerPC/PPCInstrFuture.td b/llvm/lib/Target/PowerPC/PPCInstrFuture.td
index 8cf5c850ad481..a12dfae2a0d7f 100644
--- a/llvm/lib/Target/PowerPC/PPCInstrFuture.td
+++ b/llvm/lib/Target/PowerPC/PPCInstrFuture.td
@@ -13,7 +13,7 @@
 
 class XOForm_RTAB5_L1<bits<6> opcode, bits<9> xo, dag OOL, dag IOL,
                       string asmstr, list<dag> pattern>
-         : I<opcode, OOL, IOL, asmstr, NoItinerary> {
+    : I<opcode, OOL, IOL, asmstr, NoItinerary> {
   bits<5> RT;
   bits<5> RA;
   bits<5> RB;
@@ -21,27 +21,27 @@ class XOForm_RTAB5_L1<bits<6> opcode, bits<9> xo, dag OOL, dag IOL,
 
   let Pattern = pattern;
 
-  bit RC = 0;    // set by isRecordForm
+  bit RC = 0; // set by isRecordForm
 
-  let Inst{6...10}  = RT;
+  let Inst{6...10} = RT;
   let Inst{11...15} = RA;
   let Inst{16...20} = RB;
-  let Inst{21}    = L;
+  let Inst{21} = L;
   let Inst{22...30} = xo;
-  let Inst{31}    = RC;
+  let Inst{31} = RC;
 }
 
 multiclass XOForm_RTAB5_L1r<bits<6> opcode, bits<9> xo, dag OOL, dag IOL,
-                            string asmbase, string asmstr,
-                            list<dag> pattern> {
+                            string asmbase, string asmstr, list<dag> pattern> {
   let BaseName = asmbase in {
     def NAME : XOForm_RTAB5_L1<opcode, xo, OOL, IOL,
                                !strconcat(asmbase, !strconcat(" ", asmstr)),
-                               pattern>, RecFormRel;
-    let Defs = [CR0] in
-    def _rec : XOForm_RTAB5_L1<opcode, xo, OOL, IOL,
-                               !strconcat(asmbase, !strconcat(". ", asmstr)),
-                               []>, isRecordForm, RecFormRel;
+                               pattern>,
+               RecFormRel;
+    let Defs = [CR0] in def _rec
+        : XOForm_RTAB5_L1<opcode, xo, OOL, IOL,
+                          !strconcat(asmbase, !strconcat(". ", asmstr)), []>,
+        isRecordForm, RecFormRel;
   }
 }
 
@@ -122,39 +122,40 @@ class VXForm_VRTAB5<bits<11> xo, dag OOL, dag IOL, string asmstr,
 
 let Predicates = [IsISAFuture] in {
   defm SUBFUS : XOForm_RTAB5_L1r<31, 72, (outs g8rc:$RT),
-                                 (ins g8rc:$RA, g8rc:$RB, u1imm:$L),
-                                 "subfus",  "$RT, $L, $RA, $RB", []>;
+                                 (ins g8rc:$RA, g8rc:$RB, u1imm:$L), "subfus",
+                                 "$RT, $L, $RA, $RB", []>;
 }
 
 let Predicates = [HasVSX, IsISAFuture] in {
   let mayLoad = 1 in {
-    def LXVRL
-        : XX1Form_memOp<31, 525, (outs vsrc:$XT), (ins (memr $RA):$addr, g8rc:$RB),
-                        "lxvrl $XT, $addr, $RB", IIC_LdStLoad, []>;
-    def LXVRLL
-        : XX1Form_memOp<31, 557, (outs vsrc:$XT), (ins (memr $RA):$addr, g8rc:$RB),
-                        "lxvrll $XT, $addr, $RB", IIC_LdStLoad, []>;
-    def LXVPRL
-        : XForm_XTp5_XAB5<31, 589, (outs vsrprc:$XTp), (ins (memr $RA):$addr, g8rc:$RB),
-                          "lxvprl $XTp, $addr, $RB", IIC_LdStLFD, []>;
-    def LXVPRLL
-        : XForm_XTp5_XAB5<31, 621, (outs vsrprc:$XTp), (ins (memr $RA):$addr, g8rc:$RB),
-                          "lxvprll $XTp, $addr, $RB", IIC_LdStLFD, []>;
+    def LXVRL : XX1Form_memOp<31, 525, (outs vsrc:$XT),
+                              (ins (memr $RA):$addr, g8rc:$RB),
+                              "lxvrl $XT, $addr, $RB", IIC_LdStLoad, []>;
+    def LXVRLL : XX1Form_memOp<31, 557, (outs vsrc:$XT),
+                               (ins (memr $RA):$addr, g8rc:$RB),
+                               "lxvrll $XT, $addr, $RB", IIC_LdStLoad, []>;
+    def LXVPRL : XForm_XTp5_XAB5<31, 589, (outs vsrprc:$XTp),
+                                 (ins (memr $RA):$addr, g8rc:$RB),
+                                 "lxvprl $XTp, $addr, $RB", IIC_LdStLFD, []>;
+    def LXVPRLL : XForm_XTp5_XAB5<31, 621, (outs vsrprc:$XTp),
+                                  (ins (memr $RA):$addr, g8rc:$RB),
+                                  "lxvprll $XTp, $addr, $RB", IIC_LdStLFD, []>;
   }
 
   let mayStore = 1 in {
-    def STXVRL
-        : XX1Form_memOp<31, 653, (outs), (ins vsrc:$XT, (memr $RA):$addr, g8rc:$RB),
-                        "stxvrl $XT, $addr, $RB", IIC_LdStLoad, []>;
-    def STXVRLL
-        : XX1Form_memOp<31, 685, (outs), (ins vsrc:$XT, (memr $RA):$addr, g8rc:$RB),
-                        "stxvrll $XT, $addr, $RB", IIC_LdStLoad, []>;
+    def STXVRL : XX1Form_memOp<31, 653, (outs),
+                               (ins vsrc:$XT, (memr $RA):$addr, g8rc:$RB),
+                               "stxvrl $XT, $addr, $RB", IIC_LdStLoad, []>;
+    def STXVRLL : XX1Form_memOp<31, 685, (outs),
+                                (ins vsrc:$XT, (memr $RA):$addr, g8rc:$RB),
+                                "stxvrll $XT, $addr, $RB", IIC_LdStLoad, []>;
     def STXVPRL : XForm_XTp5_XAB5<31, 717, (outs),
                                   (ins vsrprc:$XTp, (memr $RA):$addr, g8rc:$RB),
                                   "stxvprl $XTp, $addr, $RB", IIC_LdStLFD, []>;
-    def STXVPRLL : XForm_XTp5_XAB5<31, 749, (outs),
-                                   (ins vsrprc:$XTp, (memr $RA):$addr, g8rc:$RB),
-                                   "stxvprll $XTp, $addr, $RB", IIC_LdStLFD, []>;
+    def STXVPRLL
+        : XForm_XTp5_XAB5<31, 749, (outs),
+                          (ins vsrprc:$XTp, (memr $RA):$addr, g8rc:$RB),
+                          "stxvprll $XTp, $addr, $RB", IIC_LdStLFD, []>;
   }
 
   def VUPKHSNTOB : VXForm_VRTB5<387, 0, (outs vrrc:$VRT), (ins vrrc:$VRB),

@lei137 lei137 force-pushed the clangfmtPPCInstrFuture branch from 66c1a9d to c90f46a Compare September 5, 2025 16:28
@lei137 lei137 force-pushed the clangfmtPPCInstrFuture branch from c90f46a to cc20f5e Compare September 5, 2025 16:41
@lei137 lei137 merged commit a070dbb into llvm:main Sep 5, 2025
7 of 9 checks passed
@lei137 lei137 deleted the clangfmtPPCInstrFuture branch September 5, 2025 16:43
@llvm-ci
Copy link
Collaborator

llvm-ci commented Sep 5, 2025

LLVM Buildbot has detected a new failure on builder cross-project-tests-sie-ubuntu running on doug-worker-1a while building llvm at step 6 "test-build-unified-tree-check-cross-project".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/27353

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-cross-project) failure: test (failure)
******************** TEST 'cross-project-tests :: debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c' FAILED ********************
Exit Code: 2

Command Output (stderr):
--
clang -O0 -glldb -std=gnu11 /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c -o /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/Output/command_line.c.tmp # RUN: at line 4
+ clang -O0 -glldb -std=gnu11 /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c -o /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/Output/command_line.c.tmp
"/usr/bin/python3.8" "/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/dexter.py" test --fail-lt 1.0 -w --debugger lldb-dap --lldb-executable "/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/bin/lldb-dap" --binary /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/Output/command_line.c.tmp -- /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c | /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/bin/FileCheck /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c # RUN: at line 5
+ /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/bin/FileCheck /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c
+ /usr/bin/python3.8 /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/dexter.py test --fail-lt 1.0 -w --debugger lldb-dap --lldb-executable /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/bin/lldb-dap --binary /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/Output/command_line.c.tmp -- /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c


****************************************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants