Skip to content

[AArch64][GlobalISel] Fix passing <3 x ptr> via the stack. #157247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[AArch64][GlobalISel] Fix passing <3 x ptr> via the stack. #157247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,7 @@ LLT CallLowering::ValueHandler::getStackValueStoreType(
if (Flags.isPointer()) {
LLT PtrTy = LLT::pointer(Flags.getPointerAddrSpace(),
ValTy.getScalarSizeInBits());
if (ValVT.isVector())
if (ValVT.isVector() && ValVT.getVectorNumElements() != 1)
return LLT::vector(ValTy.getElementCount(), PtrTy);
return PtrTy;
}
Expand Down
35 changes: 35 additions & 0 deletions llvm/test/CodeGen/AArch64/extract-vector-elt.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,3 +1093,38 @@ loop:
ret:
ret i32 %3
}

define <3 x ptr> @v3move(<3 x ptr> %a, <3 x ptr> %b, <3 x ptr> %x) {
; CHECK-SD-LABEL: v3move:
; CHECK-SD: // %bb.0: // %entry
; CHECK-SD-NEXT: fmov d1, d7
; CHECK-SD-NEXT: fmov d0, d6
; CHECK-SD-NEXT: ldr d2, [sp]
; CHECK-SD-NEXT: ret
;
; CHECK-GI-LABEL: v3move:
; CHECK-GI: // %bb.0: // %entry
; CHECK-GI-NEXT: ldr x8, [sp]
; CHECK-GI-NEXT: fmov d0, d6
; CHECK-GI-NEXT: fmov d1, d7
; CHECK-GI-NEXT: fmov d2, x8
; CHECK-GI-NEXT: ret
entry:
ret <3 x ptr> %x
}

define ptr @v3ext(<3 x ptr> %a, <3 x ptr> %b, <3 x ptr> %x) {
; CHECK-SD-LABEL: v3ext:
; CHECK-SD: // %bb.0: // %entry
; CHECK-SD-NEXT: ldr d0, [sp]
; CHECK-SD-NEXT: fmov x0, d0
; CHECK-SD-NEXT: ret
;
; CHECK-GI-LABEL: v3ext:
; CHECK-GI: // %bb.0: // %entry
; CHECK-GI-NEXT: ldr x0, [sp]
; CHECK-GI-NEXT: ret
entry:
%c = extractelement <3 x ptr> %x, i32 2
ret ptr %c
}