[lld][WebAssembly] Remove redundant assignment. NFC

[sbc100]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lld-wasm

@llvm/pr-subscribers-lld

Author: Sam Clegg (sbc100)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/160400.diff

1 Files Affected:

• (modified) lld/wasm/Driver.cpp (-2)

diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index b57d77457b83a..6332f1a793b2a 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -556,8 +556,6 @@ static void readConfigs(opt::InputArgList &args) {
     ctx.arg.memoryExport = args.getLastArgValue(OPT_export_memory_with_name);
   } else if (args.hasArg(OPT_export_memory)) {
     ctx.arg.memoryExport = memoryName;
-  } else {
-    ctx.arg.memoryExport = std::optional<llvm::StringRef>();
   }
 
   ctx.arg.sharedMemory = args.hasArg(OPT_shared_memory);

[llvm-ci]

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-gcc-ubuntu running on sie-linux-worker3 while building lld at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/24967

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'lit :: shtest-readfile-external.py' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 4
env LIT_USE_INTERNAL_SHELL=0 not env -u FILECHECK_OPTS "/usr/bin/python3.8" /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical -a -v Inputs/shtest-readfile | FileCheck -match-full-lines -DTEMP_PATH=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/shtest-readfile-external.py
# executed command: env LIT_USE_INTERNAL_SHELL=0 not env -u FILECHECK_OPTS /usr/bin/python3.8 /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical -a -v Inputs/shtest-readfile
# note: command had no output on stdout or stderr
# executed command: FileCheck -match-full-lines -DTEMP_PATH=/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/shtest-readfile-external.py
# .---command stderr------------
# | �[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/shtest-readfile-external.py:18:10: �[0m�[0;1;31merror: �[0m�[1mCHECK: expected string not found in input
�[0m# | �[1m�[0m# CHECK: + echo hello
# | �[0;1;32m         ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:62:102: �[0m�[0;1;30mnote: �[0m�[1mscanning from here
�[0m# | �[1m�[0mecho $(cat rel_path_test_folder/test_file) && test -e rel_path_test_folder/test_file # RUN: at line 4
# | �[0;1;32m                                                                                                     ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:67:1: �[0m�[0;1;30mnote: �[0m�[1mpossible intended match here
�[0m# | �[1m�[0m+ not echo return
# | �[0;1;32m^
�[0m# | �[0;1;32m�[0m
# | Input file: <stdin>
# | Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/shtest-readfile-external.py
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# | �[1m�[0m�[0;1;30m            1: �[0m�[1m�[0;1;46m�[0m-- Testing: 4 tests, 1 workers --�[0;1;46m �[0m
# | �[0;1;32mcheck:6        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;30m            2: �[0m�[1m�[0;1;46m�[0mFAIL: shtest-readfile :: absolute-paths.txt (1 of 4)�[0;1;46m �[0m
# | �[0;1;32mlabel:8'0      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;32mlabel:8'1      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;30m            3: �[0m�[1m�[0;1;46m******************** TEST 'shtest-readfile :: absolute-paths.txt' FAILED ******************** �[0m
# | �[0;1;30m            4: �[0m�[1m�[0;1;46mExit Code: 1 �[0m
# | �[0;1;30m            5: �[0m�[1m�[0;1;46m �[0m
# | �[0;1;30m            6: �[0m�[1m�[0;1;46mCommand Output (stdout): �[0m
# | �[0;1;30m            7: �[0m�[1m�[0;1;46m-- �[0m
# | �[0;1;30m            8: �[0m�[1m�[0;1;46mhello �[0m
# | �[0;1;30m            9: �[0m�[1m�[0;1;46mreturn �[0m
# | �[0;1;30m           10: �[0m�[1m�[0;1;46m �[0m
# | �[0;1;30m           11: �[0m�[1m�[0;1;46m-- �[0m
# | �[0;1;30m           12: �[0m�[1m�[0;1;46mCommand Output (stderr): �[0m
# | �[0;1;30m           13: �[0m�[1m�[0;1;46m-- �[0m
# | �[0;1;30m           14: �[0m�[1m�[0;1;46mecho -n "hello" > /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output/absolute-paths.txt.tmp # RUN: at line 2 �[0m
# | �[0;1;30m           15: �[0m�[1m�[0;1;46m+ echo -n hello �[0m
# | �[0;1;30m           16: �[0m�[1m�[0;1;46m�[0mecho $(cat /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output/absolute-paths.txt.tmp) && test -e /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output/absolute-paths.txt.tmp # RUN: at line 3�[0;1;46m �[0m
# | �[0;1;32mcheck:9'0      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;32mcheck:9'1                                                                                                                                                                                                                                                                                                                         with "TEMP_PATH" equal to "/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output"
�[0m# | �[0;1;32m�[0m�[0;1;32mcheck:9'2                                                                                                                                                                                                                                                                                                                         with "TEMP_PATH" equal to "/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/utils/lit/tests/Inputs/shtest-readfile/Output"
...